Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1925733002: Remove the rtc_relative_path GYP variable and similar defines (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the rtc_relative_path GYP variable and similar defines This is a reland of https://codereview.webrtc.org/1903553003/ but with the SRTP changes removed, since they're needed downstream. The defines that can be used to alter the include paths for Expat and gtest are no longer needed in WebRTC or Chromium. Remove them to simplify GYP. Removed defines: EXPAT_RELATIVE_PATH GTEST_RELATIVE_PATH They're all set in the Chromium build so this shouldn't affect Chromium: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle.gyp BUG=webrtc:4256 NOTRY=True NOPRESUBMIT=True TBR=perkj@webrtc.org Committed: https://crrev.com/081254f2c62037d016f9fc961764c6f01cb095da Cr-Commit-Position: refs/heads/master@{#12536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M webrtc/base/base_tests.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/base/gunit.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/gunit_prod.h View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/build/common.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmllite/xmlbuilder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmllite/xmlparser.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppstanzaparser.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925733002/1
4 years, 7 months ago (2016-04-27 17:13:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 17:13:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/081254f2c62037d016f9fc961764c6f01cb095da Cr-Commit-Position: refs/heads/master@{#12536}
4 years, 7 months ago (2016-05-01 22:00:58 UTC) #5
phoglund
4 years, 7 months ago (2016-05-04 07:51:28 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1945803003/ by phoglund@webrtc.org.

The reason for reverting is: Breaks downstream gtest usage..

Powered by Google App Engine
This is Rietveld 408576698