Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1925053002: Revert of Avoiding overflow in cross correlation in NetEq. (Closed)

Created:
4 years, 7 months ago by minyue-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Avoiding overflow in cross correlation in NetEq. (patchset #6 id:180001 of https://codereview.webrtc.org/1908623002/ ) Reason for revert: There seems an error made in this patch. Hi Henrik, I think the bit shift returned by CrossCorrelationWithAutoShift may be wrongly used by DotProduct. We'd better revert this CL. Doing another fix (and future fixes) will be paintful. I will work on a easy-to-modify bitexactness test first. Original issue's description: > Avoiding overflow in cross correlation in NetEq. > > BUG= TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8c22962474c8ec9184d2475951829689640e864b Cr-Commit-Position: refs/heads/master@{#12543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -186 lines) Patch
M resources/audio_coding/neteq4_network_stats_android.dat.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_opus_network_stats.dat.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_opus_ref.pcm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_opus_ref_win_32.pcm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_opus_ref_win_64.pcm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_universal_ref.pcm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_universal_ref_android.pcm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_universal_ref_win_32.pcm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M resources/audio_coding/neteq4_universal_ref_win_64.pcm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/signal_processing/cross_correlation.c View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 2 chunks +20 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/background_noise.cc View 2 chunks +8 lines, -4 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/cross_correlation.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/cross_correlation.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.h View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.cc View 8 chunks +34 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/merge.h View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/merge.cc View 6 chunks +21 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/time_stretch.cc View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
minyue-webrtc
Created Revert of Avoiding overflow in cross correlation in NetEq.
4 years, 7 months ago (2016-04-28 09:16:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925053002/1
4 years, 7 months ago (2016-04-28 09:16:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 09:16:52 UTC) #4
hlundin-webrtc
lgtm
4 years, 7 months ago (2016-04-28 09:27:26 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c22962474c8ec9184d2475951829689640e864b
Cr-Commit-Position: refs/heads/master@{#12543}

Powered by Google App Engine
This is Rietveld 408576698