Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webrtc/media/engine/fakewebrtccall.h

Issue 1924793002: Remove webrtc/stream.h and unutilized inheritance. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/fakewebrtccall.h
diff --git a/webrtc/media/engine/fakewebrtccall.h b/webrtc/media/engine/fakewebrtccall.h
index ee3e449b199445d4601e850c26f88e2cd114fdb5..a787ff568f709fe66574aef786e4a815a202016d 100644
--- a/webrtc/media/engine/fakewebrtccall.h
+++ b/webrtc/media/engine/fakewebrtccall.h
@@ -47,15 +47,13 @@ class FakeAudioSendStream final : public webrtc::AudioSendStream {
bool IsSending() const { return sending_; }
private:
- // webrtc::SendStream implementation.
+ // webrtc::AudioSendStream implementation.
void Start() override { sending_ = true; }
void Stop() override { sending_ = false; }
- void SignalNetworkState(webrtc::NetworkState state) override {}
bool DeliverRtcp(const uint8_t* packet, size_t length) override {
The Sun (google.com) 2016/04/27 19:39:46 Unused, remove.
return true;
}
- // webrtc::AudioSendStream implementation.
bool SendTelephoneEvent(int payload_type, int event,
int duration_ms) override;
webrtc::AudioSendStream::Stats GetStats() const override;
@@ -78,10 +76,9 @@ class FakeAudioReceiveStream final : public webrtc::AudioReceiveStream {
const webrtc::AudioSinkInterface* sink() const { return sink_.get(); }
private:
- // webrtc::ReceiveStream implementation.
+ // webrtc::AudioReceiveStream implementation.
void Start() override {}
void Stop() override {}
- void SignalNetworkState(webrtc::NetworkState state) override {}
bool DeliverRtcp(const uint8_t* packet, size_t length) override {
The Sun (google.com) 2016/04/27 19:39:46 etc
return true;
}
@@ -91,7 +88,6 @@ class FakeAudioReceiveStream final : public webrtc::AudioReceiveStream {
return true;
}
- // webrtc::AudioReceiveStream implementation.
webrtc::AudioReceiveStream::Stats GetStats() const override;
void SetSink(std::unique_ptr<webrtc::AudioSinkInterface> sink) override;
@@ -126,15 +122,12 @@ class FakeVideoSendStream final : public webrtc::VideoSendStream,
private:
void IncomingCapturedFrame(const webrtc::VideoFrame& frame) override;
- // webrtc::SendStream implementation.
+ // webrtc::VideoSendStream implementation.
void Start() override;
void Stop() override;
- void SignalNetworkState(webrtc::NetworkState state) override {}
bool DeliverRtcp(const uint8_t* packet, size_t length) override {
The Sun (google.com) 2016/04/27 19:39:46 etc
return true;
}
-
- // webrtc::VideoSendStream implementation.
webrtc::VideoSendStream::Stats GetStats() override;
void ReconfigureVideoEncoder(
const webrtc::VideoEncoderConfig& config) override;
@@ -168,10 +161,9 @@ class FakeVideoReceiveStream final : public webrtc::VideoReceiveStream {
void SetStats(const webrtc::VideoReceiveStream::Stats& stats);
private:
- // webrtc::ReceiveStream implementation.
+ // webrtc::VideoReceiveStream implementation.
void Start() override;
void Stop() override;
- void SignalNetworkState(webrtc::NetworkState state) override {}
bool DeliverRtcp(const uint8_t* packet, size_t length) override {
The Sun (google.com) 2016/04/27 19:39:46 etc
return true;
}
@@ -181,7 +173,6 @@ class FakeVideoReceiveStream final : public webrtc::VideoReceiveStream {
return true;
}
- // webrtc::VideoReceiveStream implementation.
webrtc::VideoReceiveStream::Stats GetStats() const override;
webrtc::VideoReceiveStream::Config config_;

Powered by Google App Engine
This is Rietveld 408576698