Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1924663003:
Reland "Set defines for Chromium" (Closed)
|
Created:
4 years, 7 months ago by kjellander_webrtc Modified:
4 years, 6 months ago Reviewers:
perkj_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReland "Set defines for Chromium"
This is a reland of https://codereview.webrtc.org/1847013002/
with the following changes:
* _USE_32BIT_TIME_T is no longer set: it was removed from Chromium
in https://codereview.chromium.org/1862443003/.
Setting it in target_defaults was likely the reason to
remoting_unittests failing in the previous attempt to land this.
* Added define for FreeBSD platform.
* Added corresponding GN changes.
Copy the defines from the target_defaults section of Chromium's
src/third_party/libjingle.gyp into our webrtc/build/common.gypi
in order to ensure the same defines are used for the Chromium build
when removing the source listings in src/third_party/libjingle.gyp.
With this CL landed, it should be possible to replace them with
dependencies on:
* webrtc/api/api.gyp:libjingle_peerconnections
* webrtc/media/media.gyp:rtc_media
* webrtc/pc/pc.gyp:rtc_pc
* webrtc/pp2/p2p.gyp:rtc_p2p
* webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp
Not ported (Windows specific):
* Precompiled headers (build/win_precompile.gypi):
since it only seems to offer a compile speedup. Will be landed
for all of WebRTC in separate CL.
BUG=webrtc:4256
NOTRY=True
Committed: https://crrev.com/f0e174aab4ce8467e68315bff832d008a733e4ff
Cr-Commit-Position: refs/heads/master@{#12959}
Patch Set 1 : #Patch Set 2 : Rebased #
Messages
Total messages: 21 (16 generated)
Description was changed from ========== Set defines to match src/third_party/libjingle for Chromium builds. This is essentially a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set. It was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. It was likely the reason to the failing remoting_unittests in the previous CL. * EXPAT_RELATIVE_PATH and GTEST_RELATIVE_PATH are not included, since they were removed in https://codereview.webrtc.org/1925733002/ Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Set defines to match src/third_party/libjingle for Chromium builds. This is essentially a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it widely was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
kjellander@webrtc.org changed reviewers: + perkj@webrtc.org
Description was changed from ========== Set defines to match src/third_party/libjingle for Chromium builds. This is essentially a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it widely was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is essentially a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it widely was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
Description was changed from ========== Reland "Set defines for Chromium" This is essentially a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it widely was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it widely was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
Description was changed from ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it widely was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
lgtm
Description was changed from ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the exception that _USE_32BIT_TIME_T is no longer set: it was removed from Chromium without any problems in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Corresponding GN changes are added. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Corresponding GN changes are added. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Added define for FreeBSD platform. * Corresponding GN changes are added. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Added define for FreeBSD platform. * Corresponding GN changes are added. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Added define for FreeBSD platform. * Added corresponding GN changes. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
This CL wasn't quite ready yet (I added you to the review line a bit too early). Changes after your review: * Added define for FreeBSD platform. * Added corresponding GN changes. Plz ignore the android_compile_x86_dbg, I didn't mean to trigger that one (see https://bugs.chromium.org/p/chromium/issues/detail?id=610145). I will also test this CL more thoroughly in Chromium before committing, to ensure I don't break our Chromium FYI bots.
Patchset #3 (id:100001) has been deleted
The CQ bit was checked by kjellander@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org Link to the patchset: https://codereview.webrtc.org/1924663003/#ps80001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924663003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924663003/80001
Message was sent while issue was closed.
Description was changed from ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Added define for FreeBSD platform. * Added corresponding GN changes. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Added define for FreeBSD platform. * Added corresponding GN changes. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Added define for FreeBSD platform. * Added corresponding GN changes. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True ========== to ========== Reland "Set defines for Chromium" This is a reland of https://codereview.webrtc.org/1847013002/ with the following changes: * _USE_32BIT_TIME_T is no longer set: it was removed from Chromium in https://codereview.chromium.org/1862443003/. Setting it in target_defaults was likely the reason to remoting_unittests failing in the previous attempt to land this. * Added define for FreeBSD platform. * Added corresponding GN changes. Copy the defines from the target_defaults section of Chromium's src/third_party/libjingle.gyp into our webrtc/build/common.gypi in order to ensure the same defines are used for the Chromium build when removing the source listings in src/third_party/libjingle.gyp. With this CL landed, it should be possible to replace them with dependencies on: * webrtc/api/api.gyp:libjingle_peerconnections * webrtc/media/media.gyp:rtc_media * webrtc/pc/pc.gyp:rtc_pc * webrtc/pp2/p2p.gyp:rtc_p2p * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp Not ported (Windows specific): * Precompiled headers (build/win_precompile.gypi): since it only seems to offer a compile speedup. Will be landed for all of WebRTC in separate CL. BUG=webrtc:4256 NOTRY=True Committed: https://crrev.com/f0e174aab4ce8467e68315bff832d008a733e4ff Cr-Commit-Position: refs/heads/master@{#12959} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f0e174aab4ce8467e68315bff832d008a733e4ff Cr-Commit-Position: refs/heads/master@{#12959} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
