webrtc/modules/desktop_capture/shared_memory.h - Issue 1924443002: Revert of Replace the remaining scoped_ptr with unique_ptr in webrtc/modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/shared_memory.h

Issue 1924443002: Revert of Replace the remaining scoped_ptr with unique_ptr in webrtc/modules/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/desktop_capture/screen_capturer_unittest.cc ('k') | webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/desktop_capture/shared_memory.h

diff --git a/webrtc/modules/desktop_capture/shared_memory.h b/webrtc/modules/desktop_capture/shared_memory.h

index 6e15f23f6b8a4a0429f2d4aa2c09228f447d03bc..45f531e0d53dfe27095804fffbc18a10f9190c0c 100644

--- a/webrtc/modules/desktop_capture/shared_memory.h

+++ b/webrtc/modules/desktop_capture/shared_memory.h

@@ -17,9 +17,8 @@

#include <windows.h>

#endif

-#include <memory>

#include "webrtc/base/constructormagic.h"

+#include "webrtc/base/scoped_ptr.h"

#include "webrtc/typedefs.h"

namespace webrtc {

@@ -70,7 +69,7 @@

SharedMemoryFactory() {}

virtual ~SharedMemoryFactory() {}

- virtual std::unique_ptr<SharedMemory> CreateSharedMemory(size_t size) = 0;

+ virtual rtc::scoped_ptr<SharedMemory> CreateSharedMemory(size_t size) = 0;

private:

RTC_DISALLOW_COPY_AND_ASSIGN(SharedMemoryFactory);