webrtc/modules/rtp_rtcp/source/rtcp_utility.h - Issue 1924443002: Revert of Replace the remaining scoped_ptr with unique_ptr in webrtc/modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_utility.h

Issue 1924443002: Revert of Replace the remaining scoped_ptr with unique_ptr in webrtc/modules/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_utility.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_utility.h b/webrtc/modules/rtp_rtcp/source/rtcp_utility.h

index 629de4e99ec83d1691d9c195943ba2ffaa9b718d..4067a40886f435201d11ad6379f88d523fb36063 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_utility.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_utility.h

@@ -13,8 +13,7 @@

#include <stddef.h> // size_t, ptrdiff_t

-#include <memory>

+#include "webrtc/base/scoped_ptr.h"

#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"

#include "webrtc/modules/rtp_rtcp/source/rtp_rtcp_config.h"

#include "webrtc/typedefs.h"

@@ -469,7 +468,7 @@

RTCPPacketTypes _packetType;

RTCPPacket _packet;

- std::unique_ptr<webrtc::rtcp::RtcpPacket> rtcp_packet_;

+ rtc::scoped_ptr<webrtc::rtcp::RtcpPacket> rtcp_packet_;

};

class RTCPPacketIterator {