Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1924363002: Added support in the AEC for refined filter adaptation. (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@51
Target Ref:
refs/pending/branch-heads/51
Project:
webrtc
Visibility:
Public.

Description

Added support in the AEC for refined filter adaptation. The following algorithmic functionality was added: -Add support for an exact regressor power to be computed which avoids the issue with the updating of the filter sometimes being unstable. -Lowered the fixed step size of the adaptive filter to 0.05 which significantly reduces the sensitivity of the adaptive filter to near-end noise, nonlinearities, doubletalk and the unmodelled echo path tail. It also reduces the tracking speed of the adaptive filter but the chosen value proved to give a sufficient tradeoff for the requirements on the adaptive filter. To allow the new functionality to be selectively applied the following was done: -A new Config was added for selectively activating the functionality. -Functionality was added in the audioprocessing and echocancellationimpl classes for passing the activation of the functionality down to the AEC algorithms. To make the code for the introduction of the functionality clean, the following refactoring was done: -The selection of the step size was moved to a single place. -The constant for the step size of the adaptive filter in extended filter mode was made local. -The state variable storing the step-size was renamed to a more describing name. When the new functionality is not activated, the changes have been tested for bitexactness on Linux. TBR=minyue@webrtc.org BUG=webrtc:5778, webrtc:5777, 603411 Review URL: https://codereview.webrtc.org/1887003002 Cr-Commit-Position: refs/heads/master@{#12384} (cherry picked from commit 0332c2db39d6f5c780ce9e92b850bcb57e24e7f8) Committed: https://chromium.googlesource.com/external/webrtc/+/ffdb392cfb40af4c2258704aaba2d46c3d70f4b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -67 lines) Patch
M webrtc/common.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 9 chunks +107 lines, -25 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 4 chunks +6 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_mips.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 3 chunks +15 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 3 chunks +81 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hlundin-webrtc
4 years, 7 months ago (2016-04-28 19:18:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ffdb392cfb40af4c2258704aaba2d46c3d70f4b6.

Powered by Google App Engine
This is Rietveld 408576698