Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 1923213002: Rename rtc::Time64 --> rtc::TimeMillis. (Closed)

Created:
4 years, 7 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pbos-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename rtc::Time64 --> rtc::TimeMillis. In the discussion on https://codereview.webrtc.org/1888593004/, a more decriptive name was suggested for Time64. BUG=webrtc:5740 Committed: https://crrev.com/1bffc1d1a4d3c7119c45a25b54e06476b27d32ff Cr-Commit-Position: refs/heads/master@{#12594}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clarify TODO comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M webrtc/base/timeutils.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/base/timeutils.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/timeutils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/port.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/relayport.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/relayserver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/stunport.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/stunrequest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/stunrequest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/turnserver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nisse-webrtc
Some things which are unclear: 1. What's the plan for rtc::Time32 and making rtc::Time() return ...
4 years, 7 months ago (2016-04-27 09:39:11 UTC) #2
tommi
lgtm % nit. Can you ask holmer@ about the need for 32 bit timestamps? https://codereview.webrtc.org/1923213002/diff/1/webrtc/base/timeutils.h ...
4 years, 7 months ago (2016-04-27 13:26:16 UTC) #3
the sun
lgtm I like the name TimeMillis()! https://codereview.webrtc.org/1923213002/diff/1/webrtc/base/timeutils.h File webrtc/base/timeutils.h (right): https://codereview.webrtc.org/1923213002/diff/1/webrtc/base/timeutils.h#newcode41 webrtc/base/timeutils.h:41: // TODO(honghaiz): Returns ...
4 years, 7 months ago (2016-04-27 19:45:59 UTC) #4
stefan-webrtc
lgtm
4 years, 7 months ago (2016-05-02 10:38:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923213002/20001
4 years, 7 months ago (2016-05-02 13:41:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 15:18:59 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 15:19:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bffc1d1a4d3c7119c45a25b54e06476b27d32ff
Cr-Commit-Position: refs/heads/master@{#12594}

Powered by Google App Engine
This is Rietveld 408576698