Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1923163003: Replace scoped_ptr with unique_ptr in webrtc/p2p/ (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/p2p/ But keep #including scoped_ptr.h in .h files, so as not to break WebRTC users who expect those .h files to give them rtc::scoped_ptr. BUG=webrtc:5520 Committed: https://crrev.com/3ec4679dd253b2488d8f09331ffec0dcab1d3abc Cr-Commit-Position: refs/heads/master@{#12532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -261 lines) Patch
M webrtc/p2p/base/asyncstuntcpsocket_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/p2p/base/basicpacketsocketfactory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransport.h View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 8 chunks +15 lines, -13 lines 0 comments Download
M webrtc/p2p/base/port.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/port.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 42 chunks +84 lines, -93 lines 0 comments Download
M webrtc/p2p/base/pseudotcp.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/relayport_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/p2p/base/relayserver_unittest.cc View 16 chunks +27 lines, -34 lines 0 comments Download
M webrtc/p2p/base/stun.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/p2p/base/stun_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunport.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunport_unittest.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M webrtc/p2p/base/stunrequest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunserver.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunserver_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/p2p/base/tcpport.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/p2p/base/testrelayserver.h View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/p2p/base/transportdescription.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M webrtc/p2p/base/turnserver.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/p2p/client/fakeportallocator.h View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M webrtc/p2p/quic/quicconnectionhelper_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/p2p/quic/quicsession.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/p2p/quic/quicsession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/quic/quicsession_unittest.cc View 10 chunks +18 lines, -17 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.h View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M webrtc/p2p/quic/reliablequicstream_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/p2p/stunprober/main.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 7 months ago (2016-04-27 12:09:06 UTC) #2
tommi
lgtm
4 years, 7 months ago (2016-04-27 13:19:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923163003/1
4 years, 7 months ago (2016-04-27 13:26:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 14:22:57 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 14:23:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ec4679dd253b2488d8f09331ffec0dcab1d3abc
Cr-Commit-Position: refs/heads/master@{#12532}

Powered by Google App Engine
This is Rietveld 408576698