webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc - Issue 1922483002: De-flake VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

Issue 1922483002: De-flake VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h ('K') | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h ('k') | webrtc/modules/congestion_controller/congestion_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

index 785267d8c9705eef722b9293d3b381e92e60cefe..a1b78a257c6620fae93bbfd9dc1a7f53fceda5e4 100644

--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

@@ -67,6 +67,14 @@ SendSideBandwidthEstimation::SendSideBandwidthEstimation()

SendSideBandwidthEstimation::~SendSideBandwidthEstimation() {}

+void SendSideBandwidthEstimation::SetBitrates(int send_bitrate,

+ int min_bitrate,

+ int max_bitrate) {

+ if (send_bitrate > 0)

+ SetSendBitrate(send_bitrate);

+ SetMinMaxBitrate(min_bitrate, max_bitrate);

void SendSideBandwidthEstimation::SetSendBitrate(int bitrate) {

RTC_DCHECK_GT(bitrate, 0);

bitrate_ = bitrate;