webrtc/modules/bitrate_controller/bitrate_controller_impl.cc - Issue 1922483002: De-flake VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

Issue 1922483002: De-flake VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/bitrate_controller_impl.h ('k') | webrtc/modules/bitrate_controller/include/bitrate_controller.h » ('j') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

diff --git a/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc b/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

index bf608789d5d7462110f9c6e434d4def02a09c79e..3c0d37c3b04c66c974f9b8830ba7a4cb47c127db 100644

--- a/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

+++ b/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

@@ -122,6 +122,18 @@ void BitrateControllerImpl::SetMinMaxBitrate(int min_bitrate_bps,

MaybeTriggerOnNetworkChanged();

}

+void BitrateControllerImpl::SetBitrates(int start_bitrate_bps,

+ int min_bitrate_bps,

+ int max_bitrate_bps) {

+ {

+ rtc::CritScope cs(&critsect_);

+ bandwidth_estimation_.SetBitrates(start_bitrate_bps,

+ min_bitrate_bps,

+ max_bitrate_bps);

+ }

+ MaybeTriggerOnNetworkChanged();

void BitrateControllerImpl::SetReservedBitrate(uint32_t reserved_bitrate_bps) {

{

rtc::CritScope cs(&critsect_);