webrtc/modules/bitrate_controller/include/bitrate_controller.h - Issue 1922483002: De-flake VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly

Side by Side Diff: webrtc/modules/bitrate_controller/include/bitrate_controller.h

Issue 1922483002: De-flake VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback fixes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/modules/bitrate_controller/bitrate_controller_impl.cc ('K') | « webrtc/modules/bitrate_controller/bitrate_controller_impl.cc ('k') | webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h » ('j') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 *	9 *

10 * Usage: this class will register multiple RtcpBitrateObserver's one at each	10 * Usage: this class will register multiple RtcpBitrateObserver's one at each

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 // BitrateObservers.	47 // BitrateObservers.

48 public:	48 public:

49 static const int kDefaultStartBitrateKbps = 300;	49 static const int kDefaultStartBitrateKbps = 300;

50	50

51 static BitrateController* CreateBitrateController(Clock* clock,	51 static BitrateController* CreateBitrateController(Clock* clock,

52 BitrateObserver* observer);	52 BitrateObserver* observer);

53 virtual ~BitrateController() {}	53 virtual ~BitrateController() {}

54	54

55 virtual RtcpBandwidthObserver* CreateRtcpBandwidthObserver() = 0;	55 virtual RtcpBandwidthObserver* CreateRtcpBandwidthObserver() = 0;

56	56

57 virtual void SetStartBitrate(int start_bitrate_bps) = 0;	57 virtual void SetStartBitrate(int start_bitrate_bps) = 0;
	stefan-webrtc 2016/04/28 10:49:11 Deprecate these. Deprecate these. philipel 2016/04/28 11:17:19 Done. Show quoted text On 2016/04/28 10:49:11, stefan-webrtc (holmer) wrote: > Deprecate these. Done.
58 virtual void SetMinMaxBitrate(int min_bitrate_bps, int max_bitrate_bps) = 0;	58 virtual void SetMinMaxBitrate(int min_bitrate_bps, int max_bitrate_bps) = 0;

	59 virtual void SetMinMaxStartBitrate(int min_bitrate_bps,

	60 int max_bitrate_bps,

	61 int start_bitrate_bps) = 0;

59	62

60 virtual void UpdateDelayBasedEstimate(uint32_t bitrate_bps) = 0;	63 virtual void UpdateDelayBasedEstimate(uint32_t bitrate_bps) = 0;

61	64

62 virtual void SetEventLog(RtcEventLog* event_log) = 0;	65 virtual void SetEventLog(RtcEventLog* event_log) = 0;

63	66

64 // Gets the available payload bandwidth in bits per second. Note that	67 // Gets the available payload bandwidth in bits per second. Note that

65 // this bandwidth excludes packet headers.	68 // this bandwidth excludes packet headers.

66 virtual bool AvailableBandwidth(uint32_t* bandwidth) const = 0;	69 virtual bool AvailableBandwidth(uint32_t* bandwidth) const = 0;

67	70

68 virtual void SetReservedBitrate(uint32_t reserved_bitrate_bps) = 0;	71 virtual void SetReservedBitrate(uint32_t reserved_bitrate_bps) = 0;

69 };	72 };

70 } // namespace webrtc	73 } // namespace webrtc

71 #endif // WEBRTC_MODULES_BITRATE_CONTROLLER_INCLUDE_BITRATE_CONTROLLER_H_	74 #endif // WEBRTC_MODULES_BITRATE_CONTROLLER_INCLUDE_BITRATE_CONTROLLER_H_

OLD	NEW