Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Issue 1922103002: Remove "This file includes unit tests" comments. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), kwiberg-webrtc, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove "This file includes unit tests" comments. Superfluous, neteq_unittests.cc conveys that the file contains unittests for NetEq for instance. BUG= TBR=henrik.lundin@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/d98d4571340d36de5d970f9bbcedfb797cec9bc7 Cr-Commit-Position: refs/heads/master@{#12504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/qm_select_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_remb_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pbos-webrtc
Committed patchset #1 (id:1) manually as d98d4571340d36de5d970f9bbcedfb797cec9bc7 (presubmit successful).
4 years, 8 months ago (2016-04-26 11:44:07 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d98d4571340d36de5d970f9bbcedfb797cec9bc7 Cr-Commit-Position: refs/heads/master@{#12504}
4 years, 8 months ago (2016-04-26 11:44:09 UTC) #4
hlundin-webrtc
4 years, 8 months ago (2016-04-26 12:06:08 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698