webrtc/p2p/base/faketransportcontroller.h - Issue 1921653002: Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/faketransportcontroller.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/base/faketransportcontroller.h

diff --git a/webrtc/p2p/base/faketransportcontroller.h b/webrtc/p2p/base/faketransportcontroller.h

index c099c8cb796e1f132578a39631fe87670b3d434c..e2bdc1085e7513d2c4ba7ca7402c722bb5ab597d 100644

--- a/webrtc/p2p/base/faketransportcontroller.h

+++ b/webrtc/p2p/base/faketransportcontroller.h

@@ -231,7 +231,7 @@ class FakeTransportChannel : public TransportChannelImpl,

}

bool SetLocalCertificate(

- const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) {

+ const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) override {

local_cert_ = certificate;

return true;

}

@@ -257,7 +257,7 @@ class FakeTransportChannel : public TransportChannelImpl,

bool GetSslCipherSuite(int* cipher_suite) override { return false; }

- rtc::scoped_refptr<rtc::RTCCertificate> GetLocalCertificate() const {

+ rtc::scoped_refptr<rtc::RTCCertificate> GetLocalCertificate() const override {

return local_cert_;

}