webrtc/api/videotracksource.h - Issue 1921653002: Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/videotracksource.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/videotracksource.h

diff --git a/webrtc/api/videotracksource.h b/webrtc/api/videotracksource.h

index 7100612fcdba844a9b26ebb2327c8966a8fb073f..10e24ab27edf46b453d39f8900ef1eb65df0d6c0 100644

--- a/webrtc/api/videotracksource.h

+++ b/webrtc/api/videotracksource.h

@@ -36,8 +36,8 @@ class VideoTrackSource : public Notifier<VideoTrackSourceInterface> {

void Stop() override{};

void Restart() override{};

- virtual bool is_screencast() const { return false; }

- virtual rtc::Optional<bool> needs_denoising() const {

+ bool is_screencast() const override { return false; }

+ rtc::Optional<bool> needs_denoising() const override {

return rtc::Optional<bool>(); }

bool GetStats(Stats* stats) override { return false; }

« no previous file with comments | « webrtc/api/videotrack.h ('k') | webrtc/api/webrtcsession.h » ('j') | no next file with comments »