Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: webrtc/base/fakesslidentity.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/fakesslidentity.h
diff --git a/webrtc/base/fakesslidentity.h b/webrtc/base/fakesslidentity.h
index 6640b029c9b0aa01b768b13502302539a726339d..e6f89c0ddd9f4e18dbadcbdce0d3ac68b186d6e7 100644
--- a/webrtc/base/fakesslidentity.h
+++ b/webrtc/base/fakesslidentity.h
@@ -37,13 +37,13 @@ class FakeSSLCertificate : public rtc::SSLCertificate {
certs_.push_back(FakeSSLCertificate(*it));
}
}
- virtual FakeSSLCertificate* GetReference() const {
+ FakeSSLCertificate* GetReference() const override {
return new FakeSSLCertificate(*this);
}
- virtual std::string ToPEMString() const {
+ std::string ToPEMString() const override {
return data_;
}
- virtual void ToDER(Buffer* der_buffer) const {
+ void ToDER(Buffer* der_buffer) const override {
std::string der_string;
VERIFY(SSLIdentity::PemToDer(kPemTypeCertificate, data_, &der_string));
der_buffer->SetData(der_string.c_str(), der_string.size());
@@ -57,19 +57,19 @@ class FakeSSLCertificate : public rtc::SSLCertificate {
void set_digest_algorithm(const std::string& algorithm) {
digest_algorithm_ = algorithm;
}
- virtual bool GetSignatureDigestAlgorithm(std::string* algorithm) const {
+ bool GetSignatureDigestAlgorithm(std::string* algorithm) const override {
*algorithm = digest_algorithm_;
return true;
}
- virtual bool ComputeDigest(const std::string& algorithm,
- unsigned char* digest,
- size_t size,
- size_t* length) const {
+ bool ComputeDigest(const std::string& algorithm,
+ unsigned char* digest,
+ size_t size,
+ size_t* length) const override {
*length = rtc::ComputeDigest(algorithm, data_.c_str(), data_.size(),
digest, size);
return (*length != 0);
}
- virtual std::unique_ptr<SSLCertChain> GetChain() const {
+ std::unique_ptr<SSLCertChain> GetChain() const override {
if (certs_.empty())
return nullptr;
std::vector<SSLCertificate*> new_certs(certs_.size());

Powered by Google App Engine
This is Rietveld 408576698