Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Side by Side Diff: webrtc/api/videotracksource.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/videotrack.h ('k') | webrtc/api/webrtcsession.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 18 matching lines...) Expand all
29 // when the underlying rtc::VideoSourceInterface is destroyed before the 29 // when the underlying rtc::VideoSourceInterface is destroyed before the
30 // reference counted VideoTrackSource. 30 // reference counted VideoTrackSource.
31 void OnSourceDestroyed(); 31 void OnSourceDestroyed();
32 32
33 SourceState state() const override { return state_; } 33 SourceState state() const override { return state_; }
34 bool remote() const override { return remote_; } 34 bool remote() const override { return remote_; }
35 35
36 void Stop() override{}; 36 void Stop() override{};
37 void Restart() override{}; 37 void Restart() override{};
38 38
39 virtual bool is_screencast() const { return false; } 39 bool is_screencast() const override { return false; }
40 virtual rtc::Optional<bool> needs_denoising() const { 40 rtc::Optional<bool> needs_denoising() const override {
41 return rtc::Optional<bool>(); } 41 return rtc::Optional<bool>(); }
42 42
43 bool GetStats(Stats* stats) override { return false; } 43 bool GetStats(Stats* stats) override { return false; }
44 44
45 void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink, 45 void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
46 const rtc::VideoSinkWants& wants) override; 46 const rtc::VideoSinkWants& wants) override;
47 void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override; 47 void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;
48 48
49 private: 49 private:
50 rtc::ThreadChecker worker_thread_checker_; 50 rtc::ThreadChecker worker_thread_checker_;
51 rtc::VideoSourceInterface<cricket::VideoFrame>* source_; 51 rtc::VideoSourceInterface<cricket::VideoFrame>* source_;
52 cricket::VideoOptions options_; 52 cricket::VideoOptions options_;
53 SourceState state_; 53 SourceState state_;
54 const bool remote_; 54 const bool remote_;
55 }; 55 };
56 56
57 } // namespace webrtc 57 } // namespace webrtc
58 58
59 #endif // WEBRTC_API_VIDEOTRACKSOURCE_H_ 59 #endif // WEBRTC_API_VIDEOTRACKSOURCE_H_
OLDNEW
« no previous file with comments | « webrtc/api/videotrack.h ('k') | webrtc/api/webrtcsession.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698