Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: webrtc/media/engine/fakewebrtcvoiceengine.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2010 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 } 303 }
304 WEBRTC_STUB(StopSend, (int channel)); 304 WEBRTC_STUB(StopSend, (int channel));
305 WEBRTC_STUB(GetVersion, (char version[1024])); 305 WEBRTC_STUB(GetVersion, (char version[1024]));
306 WEBRTC_STUB(LastError, ()); 306 WEBRTC_STUB(LastError, ());
307 WEBRTC_FUNC(AssociateSendChannel, (int channel, 307 WEBRTC_FUNC(AssociateSendChannel, (int channel,
308 int accociate_send_channel)) { 308 int accociate_send_channel)) {
309 WEBRTC_CHECK_CHANNEL(channel); 309 WEBRTC_CHECK_CHANNEL(channel);
310 channels_[channel]->associate_send_channel = accociate_send_channel; 310 channels_[channel]->associate_send_channel = accociate_send_channel;
311 return 0; 311 return 0;
312 } 312 }
313 webrtc::RtcEventLog* GetEventLog() { return nullptr; } 313 webrtc::RtcEventLog* GetEventLog() override { return nullptr; }
314 314
315 // webrtc::VoECodec 315 // webrtc::VoECodec
316 WEBRTC_STUB(NumOfCodecs, ()); 316 WEBRTC_STUB(NumOfCodecs, ());
317 WEBRTC_STUB(GetCodec, (int index, webrtc::CodecInst& codec)); 317 WEBRTC_STUB(GetCodec, (int index, webrtc::CodecInst& codec));
318 WEBRTC_FUNC(SetSendCodec, (int channel, const webrtc::CodecInst& codec)) { 318 WEBRTC_FUNC(SetSendCodec, (int channel, const webrtc::CodecInst& codec)) {
319 WEBRTC_CHECK_CHANNEL(channel); 319 WEBRTC_CHECK_CHANNEL(channel);
320 // To match the behavior of the real implementation. 320 // To match the behavior of the real implementation.
321 if (_stricmp(codec.plname, "telephone-event") == 0 || 321 if (_stricmp(codec.plname, "telephone-event") == 0 ||
322 _stricmp(codec.plname, "audio/telephone-event") == 0 || 322 _stricmp(codec.plname, "audio/telephone-event") == 0 ||
323 _stricmp(codec.plname, "CN") == 0 || 323 _stricmp(codec.plname, "CN") == 0 ||
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 WEBRTC_STUB(GetPlayoutDeviceName, (int i, char* name, char* guid)); 454 WEBRTC_STUB(GetPlayoutDeviceName, (int i, char* name, char* guid));
455 WEBRTC_STUB(SetRecordingDevice, (int, webrtc::StereoChannel)); 455 WEBRTC_STUB(SetRecordingDevice, (int, webrtc::StereoChannel));
456 WEBRTC_STUB(SetPlayoutDevice, (int)); 456 WEBRTC_STUB(SetPlayoutDevice, (int));
457 WEBRTC_STUB(SetAudioDeviceLayer, (webrtc::AudioLayers)); 457 WEBRTC_STUB(SetAudioDeviceLayer, (webrtc::AudioLayers));
458 WEBRTC_STUB(GetAudioDeviceLayer, (webrtc::AudioLayers&)); 458 WEBRTC_STUB(GetAudioDeviceLayer, (webrtc::AudioLayers&));
459 WEBRTC_STUB(SetRecordingSampleRate, (unsigned int samples_per_sec)); 459 WEBRTC_STUB(SetRecordingSampleRate, (unsigned int samples_per_sec));
460 WEBRTC_STUB_CONST(RecordingSampleRate, (unsigned int* samples_per_sec)); 460 WEBRTC_STUB_CONST(RecordingSampleRate, (unsigned int* samples_per_sec));
461 WEBRTC_STUB(SetPlayoutSampleRate, (unsigned int samples_per_sec)); 461 WEBRTC_STUB(SetPlayoutSampleRate, (unsigned int samples_per_sec));
462 WEBRTC_STUB_CONST(PlayoutSampleRate, (unsigned int* samples_per_sec)); 462 WEBRTC_STUB_CONST(PlayoutSampleRate, (unsigned int* samples_per_sec));
463 WEBRTC_STUB(EnableBuiltInAEC, (bool enable)); 463 WEBRTC_STUB(EnableBuiltInAEC, (bool enable));
464 virtual bool BuiltInAECIsAvailable() const { return false; } 464 bool BuiltInAECIsAvailable() const override { return false; }
465 WEBRTC_STUB(EnableBuiltInAGC, (bool enable)); 465 WEBRTC_STUB(EnableBuiltInAGC, (bool enable));
466 virtual bool BuiltInAGCIsAvailable() const { return false; } 466 bool BuiltInAGCIsAvailable() const override { return false; }
467 WEBRTC_STUB(EnableBuiltInNS, (bool enable)); 467 WEBRTC_STUB(EnableBuiltInNS, (bool enable));
468 virtual bool BuiltInNSIsAvailable() const { return false; } 468 bool BuiltInNSIsAvailable() const override { return false; }
469 469
470 // webrtc::VoENetwork 470 // webrtc::VoENetwork
471 WEBRTC_FUNC(RegisterExternalTransport, (int channel, 471 WEBRTC_FUNC(RegisterExternalTransport, (int channel,
472 webrtc::Transport& transport)) { 472 webrtc::Transport& transport)) {
473 WEBRTC_CHECK_CHANNEL(channel); 473 WEBRTC_CHECK_CHANNEL(channel);
474 channels_[channel]->external_transport = true; 474 channels_[channel]->external_transport = true;
475 return 0; 475 return 0;
476 } 476 }
477 WEBRTC_FUNC(DeRegisterExternalTransport, (int channel)) { 477 WEBRTC_FUNC(DeRegisterExternalTransport, (int channel)) {
478 WEBRTC_CHECK_CHANNEL(channel); 478 WEBRTC_CHECK_CHANNEL(channel);
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 enabled = typing_detection_enabled_; 666 enabled = typing_detection_enabled_;
667 return 0; 667 return 0;
668 } 668 }
669 669
670 WEBRTC_STUB(TimeSinceLastTyping, (int& seconds)); 670 WEBRTC_STUB(TimeSinceLastTyping, (int& seconds));
671 WEBRTC_STUB(SetTypingDetectionParameters, (int timeWindow, 671 WEBRTC_STUB(SetTypingDetectionParameters, (int timeWindow,
672 int costPerTyping, 672 int costPerTyping,
673 int reportingThreshold, 673 int reportingThreshold,
674 int penaltyDecay, 674 int penaltyDecay,
675 int typeEventDelay)); 675 int typeEventDelay));
676 int EnableHighPassFilter(bool enable) { 676 int EnableHighPassFilter(bool enable) override {
677 highpass_filter_enabled_ = enable; 677 highpass_filter_enabled_ = enable;
678 return 0; 678 return 0;
679 } 679 }
680 bool IsHighPassFilterEnabled() { 680 bool IsHighPassFilterEnabled() override {
681 return highpass_filter_enabled_; 681 return highpass_filter_enabled_;
682 } 682 }
683 bool IsStereoChannelSwappingEnabled() { 683 bool IsStereoChannelSwappingEnabled() override {
684 return stereo_swapping_enabled_; 684 return stereo_swapping_enabled_;
685 } 685 }
686 void EnableStereoChannelSwapping(bool enable) { 686 void EnableStereoChannelSwapping(bool enable) override {
687 stereo_swapping_enabled_ = enable; 687 stereo_swapping_enabled_ = enable;
688 } 688 }
689 int GetNetEqCapacity() const { 689 int GetNetEqCapacity() const {
690 auto ch = channels_.find(last_channel_); 690 auto ch = channels_.find(last_channel_);
691 ASSERT(ch != channels_.end()); 691 ASSERT(ch != channels_.end());
692 return ch->second->neteq_capacity; 692 return ch->second->neteq_capacity;
693 } 693 }
694 bool GetNetEqFastAccelerate() const { 694 bool GetNetEqFastAccelerate() const {
695 auto ch = channels_.find(last_channel_); 695 auto ch = channels_.find(last_channel_);
696 ASSERT(ch != channels_.end()); 696 ASSERT(ch != channels_.end());
(...skipping 19 matching lines...) Expand all
716 webrtc::NsModes ns_mode_ = webrtc::kNsDefault; 716 webrtc::NsModes ns_mode_ = webrtc::kNsDefault;
717 webrtc::AgcModes agc_mode_ = webrtc::kAgcDefault; 717 webrtc::AgcModes agc_mode_ = webrtc::kAgcDefault;
718 webrtc::AgcConfig agc_config_; 718 webrtc::AgcConfig agc_config_;
719 int playout_fail_channel_ = -1; 719 int playout_fail_channel_ = -1;
720 FakeAudioProcessing audio_processing_; 720 FakeAudioProcessing audio_processing_;
721 }; 721 };
722 722
723 } // namespace cricket 723 } // namespace cricket
724 724
725 #endif // WEBRTC_MEDIA_ENGINE_FAKEWEBRTCVOICEENGINE_H_ 725 #endif // WEBRTC_MEDIA_ENGINE_FAKEWEBRTCVOICEENGINE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698