Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: webrtc/api/webrtcsession_unittest.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 ASSERT(false); 185 ASSERT(false);
186 } 186 }
187 187
188 // The ICE gathering state should always be Gathering when a candidate is 188 // The ICE gathering state should always be Gathering when a candidate is
189 // received (or possibly Completed in the case of the final candidate). 189 // received (or possibly Completed in the case of the final candidate).
190 EXPECT_NE(PeerConnectionInterface::kIceGatheringNew, ice_gathering_state_); 190 EXPECT_NE(PeerConnectionInterface::kIceGatheringNew, ice_gathering_state_);
191 } 191 }
192 192
193 // Some local candidates are removed. 193 // Some local candidates are removed.
194 void OnIceCandidatesRemoved( 194 void OnIceCandidatesRemoved(
195 const std::vector<cricket::Candidate>& candidates) { 195 const std::vector<cricket::Candidate>& candidates) override {
196 num_candidates_removed_ += candidates.size(); 196 num_candidates_removed_ += candidates.size();
197 } 197 }
198 198
199 bool oncandidatesready_; 199 bool oncandidatesready_;
200 std::vector<cricket::Candidate> mline_0_candidates_; 200 std::vector<cricket::Candidate> mline_0_candidates_;
201 std::vector<cricket::Candidate> mline_1_candidates_; 201 std::vector<cricket::Candidate> mline_1_candidates_;
202 PeerConnectionInterface::IceConnectionState ice_connection_state_; 202 PeerConnectionInterface::IceConnectionState ice_connection_state_;
203 PeerConnectionInterface::IceGatheringState ice_gathering_state_; 203 PeerConnectionInterface::IceGatheringState ice_gathering_state_;
204 size_t num_candidates_removed_ = 0; 204 size_t num_candidates_removed_ = 0;
205 }; 205 };
(...skipping 4198 matching lines...) Expand 10 before | Expand all | Expand 10 after
4404 } 4404 }
4405 4405
4406 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test 4406 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test
4407 // currently fails because upon disconnection and reconnection OnIceComplete is 4407 // currently fails because upon disconnection and reconnection OnIceComplete is
4408 // called more than once without returning to IceGatheringGathering. 4408 // called more than once without returning to IceGatheringGathering.
4409 4409
4410 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests, 4410 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
4411 WebRtcSessionTest, 4411 WebRtcSessionTest,
4412 testing::Values(ALREADY_GENERATED, 4412 testing::Values(ALREADY_GENERATED,
4413 DTLS_IDENTITY_STORE)); 4413 DTLS_IDENTITY_STORE));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698