Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: webrtc/base/BUILD.gn

Issue 1921513002: GN: Fix dependency for rtc_base_approved (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/tools/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index 115f31a0429ce2209e3f4835794a95f82a7784db..73382f19fae2c51d454d730910723bffd4646cdb 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -12,6 +12,12 @@ import("../build/webrtc.gni")
import("//build_overrides/webrtc.gni")
+config("rtc_base_approved_all_dependent_config") {
kjellander_webrtc 2016/04/25 05:44:10 I updated the rtc_base target to use the same styl
+ if (is_mac && !build_with_chromium) {
+ libs = [ "Foundation.framework" ] # needed for logging_mac.mm
+ }
+}
+
config("rtc_base_config") {
include_dirs = [
"//third_party/jsoncpp/overrides/include",
@@ -94,6 +100,7 @@ static_library("rtc_base_approved") {
deps = []
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
+ all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ]
sources = [
"array_view.h",
« no previous file with comments | « no previous file | webrtc/tools/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698