Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: webrtc/base/base.gyp

Issue 1921463002: Replace use of GetMacOSStatusErrorString (deprecated) with use of NSOSStatusErrorDomain. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix guard Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/base/logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/base.gyp
diff --git a/webrtc/base/base.gyp b/webrtc/base/base.gyp
index 0fb79bedefe0c34eec2a8e628d396bafd53c8019..0e6198c1c4226501b537cf01dfa1a7370384fb2b 100644
--- a/webrtc/base/base.gyp
+++ b/webrtc/base/base.gyp
@@ -160,8 +160,19 @@
'sources': [
'logging.cc',
'logging.h',
+ 'logging_mac.mm',
],
}],
+ ['OS=="mac" and build_with_chromium==0', {
+ 'all_dependent_settings': {
+ 'xcode_settings': {
+ 'OTHER_LDFLAGS': [
+ # needed for logging_mac.mm
+ '-framework Foundation',
kjellander_webrtc 2016/04/25 04:47:43 I'm missing a corresponding public_deps entry for
kjellander_webrtc 2016/04/25 05:42:37 Done in https://codereview.webrtc.org/1921513002/
+ ],
+ },
+ },
+ }], # OS=="mac" and build_with_chromium==0
],
},
{
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/base/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698