Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1919883002: Report dropped frames from codec thread. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Report dropped frames from codec thread. Removes data race inside QualityScaler which were called both from the codec thread and the invoking thread at the same time. BUG=webrtc:5678 R=glaznev@webrtc.org Committed: https://crrev.com/53edac6c0ee266b148270de8a5e8eb855c9cdba0 Cr-Commit-Position: refs/heads/master@{#12517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 6 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pbos-webrtc
PTAL, this fixes a data race on QualityScaler.
4 years, 8 months ago (2016-04-25 19:37:51 UTC) #1
AlexG
lgtm
4 years, 8 months ago (2016-04-26 16:40:43 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53edac6c0ee266b148270de8a5e8eb855c9cdba0 Cr-Commit-Position: refs/heads/master@{#12517}
4 years, 8 months ago (2016-04-26 22:08:50 UTC) #5
pbos-webrtc
4 years, 8 months ago (2016-04-26 22:08:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53edac6c0ee266b148270de8a5e8eb855c9cdba0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698