Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1919673002: Fix dependencies on mac in tools/BUILD.gn. (Closed)

Created:
4 years, 8 months ago by tommi
Modified:
4 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix dependencies on mac in tools/BUILD.gn. This can probly be done in a neater way but right now this is blocking the roll. TBR=kjellander@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/1d2dbdb0c07ea750a9efa11fbc88185b52cba9e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/tools/BUILD.gn View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tommi
4 years, 8 months ago (2016-04-24 16:24:25 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1d2dbdb0c07ea750a9efa11fbc88185b52cba9e9 Cr-Commit-Position: refs/heads/master@{#12480}
4 years, 8 months ago (2016-04-24 16:24:37 UTC) #3
tommi
Committed patchset #1 (id:1) manually as 1d2dbdb0c07ea750a9efa11fbc88185b52cba9e9 (presubmit successful).
4 years, 8 months ago (2016-04-24 16:24:40 UTC) #5
kjellander_webrtc
4 years, 8 months ago (2016-04-25 05:42:50 UTC) #6
Message was sent while issue was closed.
lgtm for now. I'm fixing this properly in
https://codereview.webrtc.org/1921513002/

Powered by Google App Engine
This is Rietveld 408576698