Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1918673002: Revert of Don't always downsample to 16kHz in the reverse stream in APM (Closed)

Created:
4 years, 8 months ago by tommi
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Don't always downsample to 16kHz in the reverse stream in APM (patchset #4 id:60001 of https://codereview.webrtc.org/1865633005/ ) Reason for revert: Creating a revert patch set of this to see if it could be causing the issues we see on the linux_ubsan_vptr bot now. Not landing the revert just yet. Original issue's description: > Don't always downsample to 16kHz in the reverse stream in APM > > The first approach landed here: https://codereview.webrtc.org/1773173002 > But it was partially reverted, because it affected the AEC performance, here: https://codereview.webrtc.org/1867483003/ > The main difference of this approach is that it doesn't use the 3-band splitting filter in the reverse stream, which seems to be the culprit of the AEC regression. > Also, the 2-band splitting filter has been used for the 32kHz case for a long time without any problem, and this is expanded in the CL to cover the 48kHz case as well. > > BUG=webrtc:5725 > TBR=tina.legrand@webrtc.org > > Committed: https://crrev.com/eb3603bd5e72b3a941363c559ddea99ee71d510a > Cr-Commit-Position: refs/heads/master@{#12451} TBR=peah@webrtc.org,aluebs@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M data/audio_processing/output_data_fixed.pb View Binary file 0 comments Download
M data/audio_processing/output_data_float.pb View Binary file 0 comments Download
M data/audio_processing/output_data_mac.pb View Binary file 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +11 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tommi
Created Revert of Don't always downsample to 16kHz in the reverse stream in APM
4 years, 8 months ago (2016-04-24 22:22:17 UTC) #1
tommi
On 2016/04/24 22:22:17, tommi-webrtc wrote: > Created Revert of Don't always downsample to 16kHz in ...
4 years, 8 months ago (2016-04-24 22:31:33 UTC) #2
aluebs-webrtc
4 years, 8 months ago (2016-04-25 19:58:13 UTC) #3
Message was sent while issue was closed.
On 2016/04/24 22:31:33, tommi-webrtc wrote:
> On 2016/04/24 22:22:17, tommi-webrtc wrote:
> > Created Revert of Don't always downsample to 16kHz in the reverse stream in
> APM
> 
> Looks unrelated. Not landing the revert.

:)

Powered by Google App Engine
This is Rietveld 408576698