|
|
Created:
4 years, 8 months ago by kjellander_webrtc Modified:
4 years, 8 months ago CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402)
Change log: https://chromium.googlesource.com/chromium/src/+log/882abee9ed..f8d5ba9e27
Full diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27
Changed dependencies:
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fe4d8bef5..f01fb5dc0e
* src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/beef685138..01464a5194
* src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+log/1d3e150066..84041ac212
* src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/6a0e771555..83f17eeede
DEPS diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27/DEPS
No update to Clang.
TBR=marpan@webrtc.org, stefan@webrtc.org,
NOTRY=True
(using notry due to ubsan bot giving us a hard time)
Committed: https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb
Cr-Commit-Position: refs/heads/master@{#12481}
Patch Set 1 #Messages
Total messages: 33 (11 generated)
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2595)
On 2016/04/24 10:06:26, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_gn_dbg on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2595) This should be resolved when https://codereview.webrtc.org/1921463002/ lands, then I'll tick the commit box again.
The CQ bit was checked by tommi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2599)
On 2016/04/24 15:38:53, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_gn_dbg on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2599) There was another issue that I fixed here: https://codereview.webrtc.org/1919673002/ Let's see how this goes the third time...
The CQ bit was checked by tommi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)
On 2016/04/24 16:46:38, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...) Looks like all the failed tests are doing something file related: FAILED TESTS (21/2214): /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: ApmTest.VerifyDebugDumpFloat /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: ApmTest.VerifyDebugDumpInt /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: NetEqDecodingTest.TestOpusBitExactness /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: NetEqDecodingTest.TestBitExactness /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ToggleAecLevel /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ToggleDelayAgnosticAec /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ToggleAec /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ToggleNs /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ToggleAgc /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.TransientSuppressionOn /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ChangeReverseFormat /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ChangeOutputFormat /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.ChangeInputFormat /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.VerifyAec3ExperimentalString /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.VerifyCombinedExperimentalStringInclusive /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.VerifyEmptyExperimentalString /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.VerifyRefinedAdaptiveFilterExperimentalString /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.SimpleCase /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: DebugDumpTest.VerifyCombinedExperimentalStringExclusive /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: ApmTest.DebugDump /b/build/slave/linux_ubsan_vptr/build/src/out/Release/modules_unittests: ApmTest.DebugDumpFromFileHandle
kjellander@webrtc.org changed reviewers: + pbos@webrtc.org
pbos: any idea why linux_ubsan_vptr would fail like this? The next roll run into the same problem so it's not a flake.
On 2016/04/24 19:56:47, kjellander (webrtc) wrote: > pbos: any idea why linux_ubsan_vptr would fail like this? The next roll run > into the same problem so it's not a flake. I think I'll disable the UBSan vptr bot tomorrow to unblock this...
On 2016/04/24 20:01:17, kjellander (webrtc) wrote: > On 2016/04/24 19:56:47, kjellander (webrtc) wrote: > > pbos: any idea why linux_ubsan_vptr would fail like this? The next roll run > > into the same problem so it's not a flake. > > I think I'll disable the UBSan vptr bot tomorrow to unblock this... sgtm. The failures all seem to be related to accessing the file system. I think we should just land this roll now and have it run through all the bots before we get in tomorrow.
Description was changed from ========== Roll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402) Change log: https://chromium.googlesource.com/chromium/src/+log/882abee9ed..f8d5ba9e27 Full diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fe4d8bef5..f01fb5dc0e * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/beef68... * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+... * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/6a0e771555..83f17eeede DEPS diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, ========== to ========== Roll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402) Change log: https://chromium.googlesource.com/chromium/src/+log/882abee9ed..f8d5ba9e27 Full diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fe4d8bef5..f01fb5dc0e * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/beef68... * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+... * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/6a0e771555..83f17eeede DEPS diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, NOTRY=True (using notry due to ubsan bot giving us a hard time) ==========
The CQ bit was checked by tommi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
On 2016/04/24 20:01:17, kjellander (webrtc) wrote: > On 2016/04/24 19:56:47, kjellander (webrtc) wrote: > > pbos: any idea why linux_ubsan_vptr would fail like this? The next roll run > > into the same problem so it's not a flake. > > I think I'll disable the UBSan vptr bot tomorrow to unblock this... Nothing off the bat, since there's nothing more than the -11 which looks like a SIGSEGV thing. Here's a stack: pbos@deimos:~/webrtc/src (ubsan_vptr_patch)$ ninja -C out/Debug modules_unittests && gdb --args out/Debug/modules_unittests --gtest_filter=DebugDumpTest.ToggleAec ninja: Entering directory `out/Debug' ninja: no work to do. GNU gdb (GDB) 7.9-gg17 Copyright (C) 2015 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-grtev4-linux-gnu". Type "show configuration" for configuration details. <http://go/gdb-home FAQ: http://go/gdb-faq Email: c-toolchain-team IRC: gdb> Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word". Reading symbols from out/Debug/modules_unittests...r done. Unable to determine compiler version. Skipping loading of libstdc++ pretty-printers for now. Non-google3 binary detected. (gdb) r Starting program: /usr/local/google/home/pbos/webrtc/src/out/Debug/modules_unittests --gtest_filter=DebugDumpTest.ToggleAec [Thread debugging using libthread_db enabled] Using host libthread_db library "/usr/grte/v4/lib64/libthread_db.so.1". Note: Google Test filter = DebugDumpTest.ToggleAec [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from DebugDumpTest [ RUN ] DebugDumpTest.ToggleAec Program received signal SIGSEGV, Segmentation fault. 0x0000000001ec0c5a in webrtc::audioproc::Config::Clear (this=0x3e51290) at gen/protoc_out/webrtc/modules/audio_processing/debug.pb.cc:2010 2010 ZR_(aec_enabled_, aecm_comfort_noise_enabled_); (gdb) bt #0 0x0000000001ec0c5a in webrtc::audioproc::Config::Clear (this=0x3e51290) at gen/protoc_out/webrtc/modules/audio_processing/debug.pb.cc:2010 #1 0x0000000001ecbe50 in webrtc::audioproc::Event::Clear (this=0x3e7ba90) at gen/protoc_out/webrtc/modules/audio_processing/debug.pb.cc:3216 #2 0x00000000016144ed in webrtc::AudioProcessingImpl::WriteMessageToDebugFile (debug_file=0x3e89550, filesize_limit_bytes=0x3e3fd80, crit_debug=0x3e3fd48, debug_state=0x3e3fda8) at ../../webrtc/modules/audio_processing/audio_processing_impl.cc:1377 #3 0x000000000160f14a in webrtc::AudioProcessingImpl::WriteConfigMessage (this=0x3e3fd40, forced=true) at ../../webrtc/modules/audio_processing/audio_processing_impl.cc:1461 #4 0x000000000161cf6b in webrtc::AudioProcessingImpl::StartDebugRecording (this=0x3e3fd40, filename=0x3e421d8 "/usr/local/google/home/pbos/webrtc/src/out//debug_aec0qXPo2", max_log_size_bytes=-1) at ../../webrtc/modules/audio_processing/audio_processing_impl.cc:995 #5 0x0000000001596a84 in webrtc::test::(anonymous namespace)::DebugDumpGenerator::StartRecording (this=0x7fffffffd560) at ../../webrtc/modules/audio_processing/test/debug_dump_test.cc:181 #6 0x0000000001597d7f in webrtc::test::DebugDumpTest_ToggleAec_Test::TestBody (this=0x3e3ffd0) at ../../webrtc/modules/audio_processing/test/debug_dump_test.cc:318 #7 0x0000000001b843d2 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void> (object=0x3e3ffd0, method=&virtual testing::Test::TestBody(), location=0x20f8f9b <.L.str.104> "the test body") at ../../chromium/src/testing/gtest/src/gtest.cc:2402 #8 0x0000000001b685fd in testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void> (object=0x3e3ffd0, method=&virtual testing::Test::TestBody(), location=0x20f8f9b <.L.str.104> "the test body") at ../../chromium/src/testing/gtest/src/gtest.cc:2455 #9 0x0000000001b4eac3 in testing::Test::Run (this=0x3e3ffd0) at ../../chromium/src/testing/gtest/src/gtest.cc:2474 #10 0x0000000001b4fb40 in testing::TestInfo::Run (this=0x3dfb4d0) at ../../chromium/src/testing/gtest/src/gtest.cc:2656 #11 0x0000000001b50e30 in testing::TestCase::Run (this=0x3dfac60) at ../../chromium/src/testing/gtest/src/gtest.cc:2774 #12 0x0000000001b5e225 in testing::internal::UnitTestImpl::RunAllTests (this=0x3ce6230) at ../../chromium/src/testing/gtest/src/gtest.cc:4647 #13 0x0000000001b8c272 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x3ce6230, method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x1b5d100 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x20f96f2 <.L.str.228> "auxiliary test code (environments or event listeners)") at ../../chromium/src/testing/gtest/src/gtest.cc:2402 #14 0x0000000001b6ba6d in testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x3ce6230, method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x1b5d100 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x20f96f2 <.L.str.228> "auxiliary test code (environments or event listeners)") at ../../chromium/src/testing/gtest/src/gtest.cc:2455 #15 0x0000000001b5d0d0 in testing::UnitTest::Run (this=0x3ce1188 <testing::UnitTest::GetInstance()::instance>) at ../../chromium/src/testing/gtest/src/gtest.cc:4255 #16 0x0000000001c46ad1 in RUN_ALL_TESTS () at ../../testing/gtest/include/gtest/gtest.h:2237 #17 0x0000000001c466d5 in webrtc::test::TestSuite::Run (this=0x7fffffffe0d0) at ../../webrtc/test/test_suite.cc:47 #18 0x0000000001c463da in main (argc=2, argv=0x7fffffffe1d8) at ../../webrtc/test/run_all_unittests.cc:15
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402) Change log: https://chromium.googlesource.com/chromium/src/+log/882abee9ed..f8d5ba9e27 Full diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fe4d8bef5..f01fb5dc0e * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/beef68... * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+... * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/6a0e771555..83f17eeede DEPS diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, NOTRY=True (using notry due to ubsan bot giving us a hard time) ========== to ========== Roll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402) Change log: https://chromium.googlesource.com/chromium/src/+log/882abee9ed..f8d5ba9e27 Full diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fe4d8bef5..f01fb5dc0e * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/beef68... * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+... * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/6a0e771555..83f17eeede DEPS diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, NOTRY=True (using notry due to ubsan bot giving us a hard time) ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402) Change log: https://chromium.googlesource.com/chromium/src/+log/882abee9ed..f8d5ba9e27 Full diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fe4d8bef5..f01fb5dc0e * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/beef68... * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+... * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/6a0e771555..83f17eeede DEPS diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, NOTRY=True (using notry due to ubsan bot giving us a hard time) ========== to ========== Roll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402) Change log: https://chromium.googlesource.com/chromium/src/+log/882abee9ed..f8d5ba9e27 Full diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fe4d8bef5..f01fb5dc0e * src/third_party/ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/beef68... * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+... * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/6a0e771555..83f17eeede DEPS diff: https://chromium.googlesource.com/chromium/src/+/882abee9ed..f8d5ba9e27/DEPS No update to Clang. TBR=marpan@webrtc.org, stefan@webrtc.org, NOTRY=True (using notry due to ubsan bot giving us a hard time) Committed: https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb Cr-Commit-Position: refs/heads/master@{#12481} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb Cr-Commit-Position: refs/heads/master@{#12481}
Message was sent while issue was closed.
On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb > Cr-Commit-Position: refs/heads/master@{#12481} I took a quick look and the only change I see in the AudioProcessingImpl code is this one: https://codereview.webrtc.org/1865633005
Message was sent while issue was closed.
On 2016/04/24 22:18:46, tommi-webrtc wrote: > On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb > > Cr-Commit-Position: refs/heads/master@{#12481} > > I took a quick look and the only change I see in the AudioProcessingImpl code is > this one: > https://codereview.webrtc.org/1865633005 For me locally it required the Chromium roll to trigger (but I hadn't sync'ed forever before this change), and on the bot as well, so I'm not sure what's really being triggered. I see no clang update in this version though.
Message was sent while issue was closed.
On 2016/04/24 22:26:58, pbos-webrtc wrote: > On 2016/04/24 22:18:46, tommi-webrtc wrote: > > On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: > > > Patchset 1 (id:??) landed as > > > https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb > > > Cr-Commit-Position: refs/heads/master@{#12481} > > > > I took a quick look and the only change I see in the AudioProcessingImpl code > is > > this one: > > https://codereview.webrtc.org/1865633005 > > For me locally it required the Chromium roll to trigger (but I hadn't sync'ed > forever before this change), and on the bot as well, so I'm not sure what's > really being triggered. I see no clang update in this version though. Yeah looks like some issue with protobuf. Not sure what it is.
Message was sent while issue was closed.
On 2016/04/24 22:58:28, tommi-webrtc wrote: > On 2016/04/24 22:26:58, pbos-webrtc wrote: > > On 2016/04/24 22:18:46, tommi-webrtc wrote: > > > On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: > > > > Patchset 1 (id:??) landed as > > > > https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb > > > > Cr-Commit-Position: refs/heads/master@{#12481} > > > > > > I took a quick look and the only change I see in the AudioProcessingImpl > code > > is > > > this one: > > > https://codereview.webrtc.org/1865633005 > > > > For me locally it required the Chromium roll to trigger (but I hadn't sync'ed > > forever before this change), and on the bot as well, so I'm not sure what's > > really being triggered. I see no clang update in this version though. > > Yeah looks like some issue with protobuf. Not sure what it is. Man, you guys work late (and me early). I'll disable the tests for UBSan and file a bug for now.
Message was sent while issue was closed.
On 2016/04/25 03:30:46, kjellander (webrtc) wrote: > On 2016/04/24 22:58:28, tommi-webrtc wrote: > > On 2016/04/24 22:26:58, pbos-webrtc wrote: > > > On 2016/04/24 22:18:46, tommi-webrtc wrote: > > > > On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: > > > > > Patchset 1 (id:??) landed as > > > > > https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb > > > > > Cr-Commit-Position: refs/heads/master@{#12481} > > > > > > > > I took a quick look and the only change I see in the AudioProcessingImpl > > code > > > is > > > > this one: > > > > https://codereview.webrtc.org/1865633005 > > > > > > For me locally it required the Chromium roll to trigger (but I hadn't > sync'ed > > > forever before this change), and on the bot as well, so I'm not sure what's > > > really being triggered. I see no clang update in this version though. > > > > Yeah looks like some issue with protobuf. Not sure what it is. > > Man, you guys work late (and me early). I'll disable the tests for UBSan and > file a bug for now. Bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820 Disabling tests in https://codereview.webrtc.org/1915813002/:
Message was sent while issue was closed.
On 2016/04/25 04:20:46, kjellander (webrtc) wrote: > On 2016/04/25 03:30:46, kjellander (webrtc) wrote: > > On 2016/04/24 22:58:28, tommi-webrtc wrote: > > > On 2016/04/24 22:26:58, pbos-webrtc wrote: > > > > On 2016/04/24 22:18:46, tommi-webrtc wrote: > > > > > On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: > > > > > > Patchset 1 (id:??) landed as > > > > > > https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb > > > > > > Cr-Commit-Position: refs/heads/master@{#12481} > > > > > > > > > > I took a quick look and the only change I see in the AudioProcessingImpl > > > code > > > > is > > > > > this one: > > > > > https://codereview.webrtc.org/1865633005 > > > > > > > > For me locally it required the Chromium roll to trigger (but I hadn't > > sync'ed > > > > forever before this change), and on the bot as well, so I'm not sure > what's > > > > really being triggered. I see no clang update in this version though. > > > > > > Yeah looks like some issue with protobuf. Not sure what it is. > > > > Man, you guys work late (and me early). I'll disable the tests for UBSan and > > file a bug for now. > > Bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820 > Disabling tests in https://codereview.webrtc.org/1915813002/: Chromium updated their protobuf dependency to version 3 in https://chromium.googlesource.com/chromium/src/+/7cf8148f570a1072928fa9ede6e0..., which is rolled in with this CL. That's probably what causes this. |