Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1918663002: Roll chromium_revision 882abee9ed..f8d5ba9e27 (388532:389402) (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
4 years, 8 months ago (2016-04-24 10:01:07 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2595)
4 years, 8 months ago (2016-04-24 10:06:26 UTC) #4
tommi
On 2016/04/24 10:06:26, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-24 14:07:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
4 years, 8 months ago (2016-04-24 15:33:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2599)
4 years, 8 months ago (2016-04-24 15:38:53 UTC) #9
tommi
On 2016/04/24 15:38:53, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-24 16:25:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
4 years, 8 months ago (2016-04-24 16:25:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/2001)
4 years, 8 months ago (2016-04-24 16:46:38 UTC) #14
tommi
On 2016/04/24 16:46:38, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-24 17:05:41 UTC) #15
kjellander_webrtc
pbos: any idea why linux_ubsan_vptr would fail like this? The next roll run into the ...
4 years, 8 months ago (2016-04-24 19:56:47 UTC) #17
kjellander_webrtc
On 2016/04/24 19:56:47, kjellander (webrtc) wrote: > pbos: any idea why linux_ubsan_vptr would fail like ...
4 years, 8 months ago (2016-04-24 20:01:17 UTC) #18
tommi
On 2016/04/24 20:01:17, kjellander (webrtc) wrote: > On 2016/04/24 19:56:47, kjellander (webrtc) wrote: > > ...
4 years, 8 months ago (2016-04-24 21:50:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918663002/1
4 years, 8 months ago (2016-04-24 21:51:36 UTC) #22
pbos-webrtc
On 2016/04/24 20:01:17, kjellander (webrtc) wrote: > On 2016/04/24 19:56:47, kjellander (webrtc) wrote: > > ...
4 years, 8 months ago (2016-04-24 21:55:04 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-24 21:57:17 UTC) #25
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb Cr-Commit-Position: refs/heads/master@{#12481}
4 years, 8 months ago (2016-04-24 21:57:30 UTC) #27
tommi
On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 8 months ago (2016-04-24 22:18:46 UTC) #28
pbos-webrtc
On 2016/04/24 22:18:46, tommi-webrtc wrote: > On 2016/04/24 21:57:30, commit-bot: I haz the power wrote: ...
4 years, 8 months ago (2016-04-24 22:26:58 UTC) #29
tommi
On 2016/04/24 22:26:58, pbos-webrtc wrote: > On 2016/04/24 22:18:46, tommi-webrtc wrote: > > On 2016/04/24 ...
4 years, 8 months ago (2016-04-24 22:58:28 UTC) #30
kjellander_webrtc
On 2016/04/24 22:58:28, tommi-webrtc wrote: > On 2016/04/24 22:26:58, pbos-webrtc wrote: > > On 2016/04/24 ...
4 years, 8 months ago (2016-04-25 03:30:46 UTC) #31
kjellander_webrtc
On 2016/04/25 03:30:46, kjellander (webrtc) wrote: > On 2016/04/24 22:58:28, tommi-webrtc wrote: > > On ...
4 years, 8 months ago (2016-04-25 04:20:46 UTC) #32
kjellander_webrtc
4 years, 8 months ago (2016-04-25 04:22:44 UTC) #33
Message was sent while issue was closed.
On 2016/04/25 04:20:46, kjellander (webrtc) wrote:
> On 2016/04/25 03:30:46, kjellander (webrtc) wrote:
> > On 2016/04/24 22:58:28, tommi-webrtc wrote:
> > > On 2016/04/24 22:26:58, pbos-webrtc wrote:
> > > > On 2016/04/24 22:18:46, tommi-webrtc wrote:
> > > > > On 2016/04/24 21:57:30, commit-bot: I haz the power wrote:
> > > > > > Patchset 1 (id:??) landed as
> > > > > > https://crrev.com/65440fb92ac3b78f2a7f63da6c974ab7225329fb
> > > > > > Cr-Commit-Position: refs/heads/master@{#12481}
> > > > > 
> > > > > I took a quick look and the only change I see in the
AudioProcessingImpl
> > > code
> > > > is
> > > > > this one:
> > > > > https://codereview.webrtc.org/1865633005
> > > > 
> > > > For me locally it required the Chromium roll to trigger (but I hadn't
> > sync'ed
> > > > forever before this change), and on the bot as well, so I'm not sure
> what's
> > > > really being triggered. I see no clang update in this version though.
> > > 
> > > Yeah looks like some issue with protobuf.  Not sure what it is.
> > 
> > Man, you guys work late (and me early). I'll disable the tests for UBSan and
> > file a bug for now.
> 
> Bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
> Disabling tests in https://codereview.webrtc.org/1915813002/:

Chromium updated their protobuf dependency to version 3 in
https://chromium.googlesource.com/chromium/src/+/7cf8148f570a1072928fa9ede6e0...,
which is rolled in with this CL. That's probably what causes this.

Powered by Google App Engine
This is Rietveld 408576698