Remove SendPacer from ViEEncoder

webrtc/modules/congestion_controller/congestion_controller.cc

Index: webrtc/modules/congestion_controller/congestion_controller.cc
diff --git a/webrtc/modules/congestion_controller/congestion_controller.cc b/webrtc/modules/congestion_controller/congestion_controller.cc
index 14a73fe1cdccfb1a3bdaed8f6771f5fe1af3cc1f..261eccc5c68f1d42d9907e176b716cd910fd39de 100644
--- a/webrtc/modules/congestion_controller/congestion_controller.cc
+++ b/webrtc/modules/congestion_controller/congestion_controller.cc
@@ -20,7 +20,6 @@
 #include "webrtc/base/socket.h"
 #include "webrtc/base/thread_annotations.h"
 #include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
-#include "webrtc/modules/pacing/paced_sender.h"
 #include "webrtc/modules/remote_bitrate_estimator/include/send_time_history.h"
 #include "webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h"
 #include "webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h"
@@ -138,31 +137,58 @@ class WrappingBitrateEstimator : public RemoteBitrateEstimator {
 
 CongestionController::CongestionController(
     Clock* clock,
-    BitrateObserver* bitrate_observer,
+    CongestionObserver* observer,
     RemoteBitrateObserver* remote_bitrate_observer)
     : clock_(clock),

[stefan-webrtc, 2016/05/02 12:56:47]

You should be able to call the other constructor from this one to reduce the
code duplication, right?

[perkj_webrtc, 2016/05/02 14:45:35]

I tried. But Since the pacer needs the PacketRouter it is not possible. The
alternative is to remove this ctor and always use the second. But I don't think
it make sence for Call to know how to create a pacer and and the packet router. 

+      observer_(observer),
+      packet_router_(new PacketRouter()),
       pacer_(new PacedSender(clock_,
-             &packet_router_,
-             BitrateController::kDefaultStartBitrateKbps,
-             PacedSender::kDefaultPaceMultiplier *
-                 BitrateController::kDefaultStartBitrateKbps,
-             0)),
+                             packet_router_.get(),
+                             BitrateController::kDefaultStartBitratebps)),
+      remote_bitrate_estimator_(
+          new WrappingBitrateEstimator(remote_bitrate_observer, clock_)),
+      bitrate_controller_(BitrateController::CreateBitrateController(clock_)),
+      remote_estimator_proxy_(clock_, packet_router_.get()),
+      transport_feedback_adapter_(bitrate_controller_.get(), clock_),
+      min_bitrate_bps_(RemoteBitrateEstimator::kDefaultMinBitrateBps),
+      send_queue_is_full_(false) {
+  Init();
+}
+
+CongestionController::CongestionController(
+    Clock* clock,
+    CongestionObserver* observer,
+    RemoteBitrateObserver* remote_bitrate_observer,
+    std::unique_ptr<PacketRouter> packet_router,
+    std::unique_ptr<PacedSender> pacer)
+    : clock_(clock),
+      observer_(observer),
+      packet_router_(std::move(packet_router)),
+      pacer_(std::move(pacer)),
       remote_bitrate_estimator_(
           new WrappingBitrateEstimator(remote_bitrate_observer, clock_)),
       // Constructed last as this object calls the provided callback on
       // construction.
-      bitrate_controller_(
-          BitrateController::CreateBitrateController(clock_, bitrate_observer)),
-      remote_estimator_proxy_(clock_, &packet_router_),
+      bitrate_controller_(BitrateController::CreateBitrateController(clock_)),
+      remote_estimator_proxy_(clock_, packet_router_.get()),
       transport_feedback_adapter_(bitrate_controller_.get(), clock_),
-      min_bitrate_bps_(RemoteBitrateEstimator::kDefaultMinBitrateBps) {
+      min_bitrate_bps_(RemoteBitrateEstimator::kDefaultMinBitrateBps),
+      send_queue_is_full_(false) {
+  Init();
+}
+
+CongestionController::~CongestionController() {}
+
+void CongestionController::Init() {
   transport_feedback_adapter_.SetBitrateEstimator(
       new RemoteBitrateEstimatorAbsSendTime(&transport_feedback_adapter_));
   transport_feedback_adapter_.GetBitrateEstimator()->SetMinBitrate(
       min_bitrate_bps_);
-}
-
-CongestionController::~CongestionController() {
+  // This calls the observer_, which means that the observer provided by the
+  // user must be ready to accept a bitrate update when it constructs the
+  // controller. We do this to avoid having to keep synchronized initial values
+  // in both the controller and the allocator.
+  MaybeTriggerOnNetworkChanged();
 }
 
 
@@ -189,6 +215,7 @@ void CongestionController::SetBweBitrates(int min_bitrate_bps,
   min_bitrate_bps_ = min_bitrate_bps;
   transport_feedback_adapter_.GetBitrateEstimator()->SetMinBitrate(
       min_bitrate_bps_);
+  MaybeTriggerOnNetworkChanged();
 }
 
 BitrateController* CongestionController::GetBitrateController() const {
@@ -209,10 +236,9 @@ CongestionController::GetTransportFeedbackObserver() {
   return &transport_feedback_adapter_;
 }
 
-void CongestionController::UpdatePacerBitrate(int bitrate_kbps,
-                                              int max_bitrate_kbps,
-                                              int min_bitrate_kbps) {
-  pacer_->UpdateBitrate(bitrate_kbps, max_bitrate_kbps, min_bitrate_kbps);
+void CongestionController::SetAllocatedSendBitrate(int allocated_bitrate_bps,
+                                                   int padding_bitrate_bps) {
+  pacer_->SetAllocatedSendBitrate(allocated_bitrate_bps, padding_bitrate_bps);
 }
 
 int64_t CongestionController::GetPacerQueuingDelayMs() const {
@@ -245,6 +271,26 @@ int64_t CongestionController::TimeUntilNextProcess() {
 void CongestionController::Process() {
   bitrate_controller_->Process();
   remote_bitrate_estimator_->Process();
+  MaybeTriggerOnNetworkChanged();
+}
+
+void CongestionController::MaybeTriggerOnNetworkChanged() {
+  uint32_t bitrate_bps;
+  uint8_t fraction_loss;
+  int64_t rtt;
+  bool network_changed = bitrate_controller_->GetNetworkParameters(
+      &bitrate_bps, &fraction_loss, &rtt);
+  if (network_changed)
+    pacer_->SetNetWorkEstimateTargetBitrate(bitrate_bps);

[stefan-webrtc, 2016/05/02 12:56:47]

Please rename this method. Maybe SetEstimatedBitrate

[perkj_webrtc, 2016/05/02 14:45:35]

Done.

+  bool send_queue_full =
+      pacer_->ExpectedQueueTimeMs() > PacedSender::kMaxQueueLengthMs;
+  bitrate_bps = send_queue_full ? 0 : bitrate_bps;
+  if ((network_changed && !send_queue_full) ||
+      send_queue_full != send_queue_is_full_) {
+    send_queue_is_full_ = send_queue_full;
+    observer_->OnNetworkChanged(bitrate_bps, fraction_loss, rtt);
+    return;

[stefan-webrtc, 2016/05/02 12:56:47]

Remove this line.

[perkj_webrtc, 2016/05/02 14:45:35]

Done.

+  }
 }
 
 }  // namespace webrtc