Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: webrtc/call/call.cc

Issue 1917793002: Remove SendPacer from ViEEncoder (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed code review comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index 23173decc63fbf28fcad49fdaef2886ec90a2682..089745a5e1c5adc812f2ba993300279da5f29405 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -51,8 +51,9 @@ const int Call::Config::kDefaultStartBitrateBps = 300000;
namespace internal {
-class Call : public webrtc::Call, public PacketReceiver,
- public BitrateObserver {
+class Call : public webrtc::Call,
+ public PacketReceiver,
+ public CongestionObserver {
public:
explicit Call(const Call::Config& config);
virtual ~Call();
@@ -692,10 +693,8 @@ void Call::OnNetworkChanged(uint32_t target_bitrate_bps, uint8_t fraction_loss,
pacer_bitrate_sum_kbits_ += pacer_bitrate_bps / 1000;
++num_bitrate_updates_;
}
- congestion_controller_->UpdatePacerBitrate(
- target_bitrate_bps / 1000,
- PacedSender::kDefaultPaceMultiplier * pacer_bitrate_bps / 1000,
- pad_up_to_bitrate_bps / 1000);
+ congestion_controller_->SetAllocatedSendBitrate(allocated_bitrate_bps,
stefan-webrtc 2016/05/02 12:56:47 Shouldn't this be pacer_bitrate_bps?
perkj_webrtc 2016/05/02 14:45:34 I don't think so. We should just care about what t
+ pad_up_to_bitrate_bps);
}
void Call::ConfigureSync(const std::string& sync_group) {

Powered by Google App Engine
This is Rietveld 408576698