Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1917703002: Fix an issue in external VNR when width or height not divisible by 16. (Closed)

Created:
4 years, 8 months ago by jackychen_
Modified:
4 years, 7 months ago
Reviewers:
marpan2
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix an issue in external VNR when width or height not divisible by 16. When frame width or height not divisible by 16, copy the margin to denoised frame, otherwise, the margin block (smaller than 16x16) will not be updated for non-keyframe. Committed: https://crrev.com/6650d6d1f6a67080fd566747844a939e9f468151 Cr-Commit-Position: refs/heads/master@{#12497}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -35 lines) Patch
M webrtc/modules/video_processing/test/brightness_detection_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/test/content_metrics_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/deflickering_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/denoiser_test.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.h View 1 1 chunk +8 lines, -7 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 1 9 chunks +23 lines, -19 lines 0 comments Download
M webrtc/modules/video_processing/video_denoiser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_processing/video_denoiser.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jackychen_
4 years, 8 months ago (2016-04-25 14:36:12 UTC) #3
marpan2
lgtm
4 years, 8 months ago (2016-04-25 16:34:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917703002/1
4 years, 8 months ago (2016-04-25 22:48:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 23:54:04 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:54:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6650d6d1f6a67080fd566747844a939e9f468151
Cr-Commit-Position: refs/heads/master@{#12497}

Powered by Google App Engine
This is Rietveld 408576698