Rename ViEReceiver and move ownership to VideoReceiveStream.

Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove ViEChannel::rtp_stream_receiver_.

BUG=5838
Committed: https://crrev.com/fa66659c6b5a13af3cdfcbf24e3bb88356e7f867
Cr-Commit-Position: refs/heads/master@{#12553}

[mflodman, 2016-04-28 12:07:04]

Description was changed from

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver.

BUG=
==========

to

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver.

BUG=5838
==========

[mflodman, 2016-04-28 12:10:55]

mflodman@webrtc.org changed reviewers:
+ pbos@webrtc.org

[mflodman, 2016-04-28 12:10:55]

Peter,
Can you take a look?

[mflodman, 2016-04-28 12:11:31]

Description was changed from

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver.

BUG=5838
==========

to

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove
ViEChannel::rtp_stream_receiver_.

BUG=5838
==========

[pbos-webrtc, 2016-04-28 14:26:49]

lgtm

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/rtp_stream_r...
File webrtc/video/rtp_stream_receiver.h (right):

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.h:103: 
remove empty line

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.cc:81: ViEChannel::~ViEChannel() {}
Remove dtor

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.cc:155:
rtp_stream_receiver_->RegisterRtcpPacketTypeCounterObserver(observer);
Can you move this to VideoReceiveStream since it's trivial?

[mflodman, 2016-04-29 04:50:16]

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/rtp_stream_r...
File webrtc/video/rtp_stream_receiver.h (right):

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.h:103: 
On 2016/04/28 14:26:49, pbos-webrtc wrote:
> remove empty line

Done.

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.cc:81: ViEChannel::~ViEChannel() {}
On 2016/04/28 14:26:49, pbos-webrtc wrote:
> Remove dtor

Done.

https://codereview.webrtc.org/1917363005/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.cc:155:
rtp_stream_receiver_->RegisterRtcpPacketTypeCounterObserver(observer);
On 2016/04/28 14:26:49, pbos-webrtc wrote:
> Can you move this to VideoReceiveStream since it's trivial?

I have a CL almost reay to upload as soon as this one is submitted, so you'll
have this in a review by the time you wake up :)

[mflodman, 2016-04-29 04:50:19]

The CQ bit was checked by mflodman@webrtc.org

[mflodman, 2016-04-29 04:50:20]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1917363005/#ps40001 (title:
" ")

[commit-bot: I haz the power, 2016-04-29 04:50:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917363005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917363005/40001

[commit-bot: I haz the power, 2016-04-29 04:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 04:51:56]

Try jobs failed on following builders:
  mac_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/14236)
  mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2754)
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/8976)

[mflodman, 2016-04-29 05:17:01]

The CQ bit was checked by mflodman@webrtc.org

[mflodman, 2016-04-29 05:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1917363005/#ps60001 (title:
"Add back dtoe since needed b/c ChannelStatsObserver declaration in cc")

[commit-bot: I haz the power, 2016-04-29 05:17:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917363005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917363005/60001

[commit-bot: I haz the power, 2016-04-29 06:15:37]

Description was changed from

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove
ViEChannel::rtp_stream_receiver_.

BUG=5838
==========

to

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove
ViEChannel::rtp_stream_receiver_.

BUG=5838
==========

[commit-bot: I haz the power, 2016-04-29 06:15:38]

Committed patchset #4 (id:60001)

[mflodman, 2016-04-29 06:25:48]

Description was changed from

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove
ViEChannel::rtp_stream_receiver_.

BUG=5838
==========

to

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove
ViEChannel::rtp_stream_receiver_.

BUG=webrtc:5838
==========

[commit-bot: I haz the power, 2016-05-01 22:01:32]

Description was changed from

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove
ViEChannel::rtp_stream_receiver_.

BUG=webrtc:5838
==========

to

==========
Rename ViEReceiver and move ownership to VideoReceiveStream.

This CL will be followed up with another CL removing everything related
to RTP from ViEChannel to RtpStreamReceiver, i.e. remove
ViEChannel::rtp_stream_receiver_.

BUG=5838

Committed: https://crrev.com/fa66659c6b5a13af3cdfcbf24e3bb88356e7f867
Cr-Commit-Position: refs/heads/master@{#12553}
==========

[commit-bot: I haz the power, 2016-05-01 22:01:33]

Patchset 4 (id:??) landed as
https://crrev.com/fa66659c6b5a13af3cdfcbf24e3bb88356e7f867
Cr-Commit-Position: refs/heads/master@{#12553}