Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1917323002: Remove remaining quality-analysis (QM). (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
marpan2, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove remaining quality-analysis (QM). This was never turned on, contains a lot of complexity and somehow manages triggering a bug in a downstream project. BUG=webrtc:5066 R=marpan@webrtc.org TBR=mflodman@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/ad6fc5a05cfef6f7a545b32179c44664624d423c

Patch Set 1 #

Patch Set 2 : remove unused sent_video_rate_kbps #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3991 lines) Patch
M webrtc/modules/include/module_common_types.h View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/content_metrics_processing.h View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/modules/video_coding/content_metrics_processing.cc View 1 chunk +0 lines, -126 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/media_opt_util.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/media_optimization.h View 5 chunks +1 line, -24 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.cc View 1 14 chunks +2 lines, -148 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
D webrtc/modules/video_coding/qm_select.h View 1 chunk +0 lines, -326 lines 0 comments Download
D webrtc/modules/video_coding/qm_select.cc View 1 chunk +0 lines, -901 lines 0 comments Download
D webrtc/modules/video_coding/qm_select_data.h View 1 chunk +0 lines, -227 lines 0 comments Download
D webrtc/modules/video_coding/qm_select_unittest.cc View 1 chunk +0 lines, -1302 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 4 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 2 3 4 chunks +7 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 2 3 5 chunks +3 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D webrtc/modules/video_processing/content_analysis.h View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/modules/video_processing/content_analysis.cc View 1 2 3 1 chunk +0 lines, -280 lines 0 comments Download
D webrtc/modules/video_processing/content_analysis_sse2.cc View 1 chunk +0 lines, -271 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.h View 1 2 3 chunks +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.cc View 1 2 4 chunks +1 line, -23 lines 0 comments Download
M webrtc/modules/video_processing/include/video_processing.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/modules/video_processing/test/content_metrics_test.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/video_processing.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_processing/video_processing_impl.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/video_processing_impl.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 3 4 chunks +3 lines, -41 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
pbos-webrtc
PTAL
4 years, 8 months ago (2016-04-26 21:56:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917323002/1
4 years, 8 months ago (2016-04-26 21:56:35 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3497) android_dbg on ...
4 years, 8 months ago (2016-04-26 22:00:26 UTC) #5
pbos-webrtc
remove unused sent_video_rate_kbps
4 years, 8 months ago (2016-04-26 22:07:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917323002/20001
4 years, 8 months ago (2016-04-26 22:07:55 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/2048)
4 years, 8 months ago (2016-04-26 22:14:06 UTC) #10
pbos-webrtc
rebase
4 years, 7 months ago (2016-04-28 06:48:02 UTC) #11
pbos-webrtc
Had to rebase, ptal
4 years, 7 months ago (2016-04-28 06:56:06 UTC) #12
pbos-webrtc
rebase
4 years, 7 months ago (2016-05-11 21:32:27 UTC) #13
marpan2
lgtm
4 years, 7 months ago (2016-05-11 21:34:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917323002/60001
4 years, 7 months ago (2016-05-11 22:15:16 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13199)
4 years, 7 months ago (2016-05-11 22:27:06 UTC) #18
pbos-webrtc
TBR=mflodman for webrtc/modules/include/module_common_types.h.
4 years, 7 months ago (2016-05-12 01:01:21 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/ad6fc5a05cfef6f7a545b32179c44664624d423c Cr-Commit-Position: refs/heads/master@{#12692}
4 years, 7 months ago (2016-05-12 01:01:48 UTC) #23
pbos-webrtc
4 years, 7 months ago (2016-05-12 01:01:50 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
ad6fc5a05cfef6f7a545b32179c44664624d423c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698