Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1952)

Unified Diff: webrtc/pc/channel.h

Issue 1917193008: Adding getParameters/setParameters APIs to RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding nil check and removing unneeded methods. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/channel.h
diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h
index 4518301d3b65e9e6fdf89586d258b519e42a4677..3d314d2fcae9bd6510e8428a25b3ff6bdd3e38d0 100644
--- a/webrtc/pc/channel.h
+++ b/webrtc/pc/channel.h
@@ -366,8 +366,12 @@ class VoiceChannel : public BaseChannel {
bool SetOutputVolume(uint32_t ssrc, double volume);
void SetRawAudioSink(uint32_t ssrc,
std::unique_ptr<webrtc::AudioSinkInterface> sink);
- webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const;
- bool SetRtpParameters(uint32_t ssrc, const webrtc::RtpParameters& parameters);
+ webrtc::RtpParameters GetRtpSendParameters(uint32_t ssrc) const;
+ bool SetRtpSendParameters(uint32_t ssrc,
+ const webrtc::RtpParameters& parameters);
+ webrtc::RtpParameters GetRtpReceiveParameters(uint32_t ssrc) const;
+ bool SetRtpReceiveParameters(uint32_t ssrc,
+ const webrtc::RtpParameters& parameters);
// Get statistics about the current media session.
bool GetStats(VoiceMediaInfo* stats);
@@ -388,8 +392,11 @@ class VoiceChannel : public BaseChannel {
int GetInputLevel_w();
int GetOutputLevel_w();
void GetActiveStreams_w(AudioInfo::StreamList* actives);
- webrtc::RtpParameters GetRtpParameters_w(uint32_t ssrc) const;
- bool SetRtpParameters_w(uint32_t ssrc, webrtc::RtpParameters parameters);
+ webrtc::RtpParameters GetRtpSendParameters_w(uint32_t ssrc) const;
+ bool SetRtpSendParameters_w(uint32_t ssrc, webrtc::RtpParameters parameters);
+ webrtc::RtpParameters GetRtpReceiveParameters_w(uint32_t ssrc) const;
+ bool SetRtpReceiveParameters_w(uint32_t ssrc,
+ webrtc::RtpParameters parameters);
private:
// overrides from BaseChannel
@@ -464,8 +471,12 @@ class VideoChannel : public BaseChannel {
sigslot::signal2<VideoChannel*, const VideoMediaInfo&> SignalMediaMonitor;
bool SetVideoSend(uint32_t ssrc, bool enable, const VideoOptions* options);
- webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const;
- bool SetRtpParameters(uint32_t ssrc, const webrtc::RtpParameters& parameters);
+ webrtc::RtpParameters GetRtpSendParameters(uint32_t ssrc) const;
+ bool SetRtpSendParameters(uint32_t ssrc,
+ const webrtc::RtpParameters& parameters);
+ webrtc::RtpParameters GetRtpReceiveParameters(uint32_t ssrc) const;
+ bool SetRtpReceiveParameters(uint32_t ssrc,
+ const webrtc::RtpParameters& parameters);
private:
// overrides from BaseChannel
@@ -478,8 +489,11 @@ class VideoChannel : public BaseChannel {
ContentAction action,
std::string* error_desc);
bool GetStats_w(VideoMediaInfo* stats);
- webrtc::RtpParameters GetRtpParameters_w(uint32_t ssrc) const;
- bool SetRtpParameters_w(uint32_t ssrc, webrtc::RtpParameters parameters);
+ webrtc::RtpParameters GetRtpSendParameters_w(uint32_t ssrc) const;
+ bool SetRtpSendParameters_w(uint32_t ssrc, webrtc::RtpParameters parameters);
+ webrtc::RtpParameters GetRtpReceiveParameters_w(uint32_t ssrc) const;
+ bool SetRtpReceiveParameters_w(uint32_t ssrc,
+ webrtc::RtpParameters parameters);
virtual void OnMessage(rtc::Message* pmsg);
virtual void GetSrtpCryptoSuites(std::vector<int>* crypto_suites) const;

Powered by Google App Engine
This is Rietveld 408576698