Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: webrtc/api/mediastreamprovider.h

Issue 1917193008: Adding getParameters/setParameters APIs to RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding nil check and removing unneeded methods. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/mediastreamprovider.h
diff --git a/webrtc/api/mediastreamprovider.h b/webrtc/api/mediastreamprovider.h
index eef92846cbd15c47ce3014f9da8c518c6130cf71..c0666afd825e9df265eb1e1c2cda9d31db7ea6e2 100644
--- a/webrtc/api/mediastreamprovider.h
+++ b/webrtc/api/mediastreamprovider.h
@@ -64,9 +64,14 @@ class AudioProviderInterface {
uint32_t ssrc,
std::unique_ptr<webrtc::AudioSinkInterface> sink) = 0;
- virtual RtpParameters GetAudioRtpParameters(uint32_t ssrc) const = 0;
- virtual bool SetAudioRtpParameters(uint32_t ssrc,
- const RtpParameters& parameters) = 0;
+ virtual RtpParameters GetAudioRtpSendParameters(uint32_t ssrc) const = 0;
+ virtual bool SetAudioRtpSendParameters(uint32_t ssrc,
+ const RtpParameters& parameters) = 0;
+
+ virtual RtpParameters GetAudioRtpReceiveParameters(uint32_t ssrc) const = 0;
+ virtual bool SetAudioRtpReceiveParameters(
+ uint32_t ssrc,
+ const RtpParameters& parameters) = 0;
pthatcher1 2016/05/13 18:41:53 Not blocking this CL, but can we just skip to givi
Taylor Brandstetter 2016/05/13 19:09:11 I'd prefer to do that in a separate CL, so it does
protected:
virtual ~AudioProviderInterface() {}
@@ -89,9 +94,14 @@ class VideoProviderInterface {
bool enable,
const cricket::VideoOptions* options) = 0;
- virtual RtpParameters GetVideoRtpParameters(uint32_t ssrc) const = 0;
- virtual bool SetVideoRtpParameters(uint32_t ssrc,
- const RtpParameters& parameters) = 0;
+ virtual RtpParameters GetVideoRtpSendParameters(uint32_t ssrc) const = 0;
+ virtual bool SetVideoRtpSendParameters(uint32_t ssrc,
+ const RtpParameters& parameters) = 0;
+
+ virtual RtpParameters GetVideoRtpReceiveParameters(uint32_t ssrc) const = 0;
+ virtual bool SetVideoRtpReceiveParameters(
+ uint32_t ssrc,
+ const RtpParameters& parameters) = 0;
protected:
virtual ~VideoProviderInterface() {}

Powered by Google App Engine
This is Rietveld 408576698