Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpReceiver.h

Issue 1917193008: Adding getParameters/setParameters APIs to RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding isEqual implementation for RTCRtpSender and RTCRtpReceiver Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpReceiver.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpReceiver.h
similarity index 73%
copy from webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h
copy to webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpReceiver.h
index c874b77e6bb0a508186ae94cb7c00cce1e285f2c..6ef925737d144f94a3e5ddc394b54edc4f8cdcef 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpReceiver.h
@@ -17,21 +17,25 @@
NS_ASSUME_NONNULL_BEGIN
RTC_EXPORT
-@protocol RTCRtpSender <NSObject>
+@protocol RTCRtpReceiver <NSObject>
/** The currently active RTCRtpParameters, as defined in
* https://www.w3.org/TR/webrtc/#idl-def-RTCRtpParameters.
+ *
+ * The WebRTC specification only defines RTCRtpParameters in terms of senders,
+ * but this API also applies them to receivers, similar to ORTC:
+ * http://ortc.org/wp-content/uploads/2016/03/ortc.html#rtcrtpparameters*.
*/
@property(nonatomic, readonly) RTCRtpParameters *parameters;
-/** The RTCMediaStreamTrack associated with the sender.
+/** The RTCMediaStreamTrack associated with the receiver.
* Note: reading this property returns a new instance of
* RTCMediaStreamTrack. Use isEqual: instead of == to compare
* RTCMediaStreamTrack instances.
*/
@property(nonatomic, readonly) RTCMediaStreamTrack *track;
-/** Set the new RTCRtpParameters to be used by the sender.
+/** Set the new RTCRtpParameters to be used by the receiver.
* Returns YES if the new parameters were applied, NO otherwise.
*/
- (BOOL)setParameters:(RTCRtpParameters *)parameters;
@@ -39,7 +43,7 @@ RTC_EXPORT
@end
RTC_EXPORT
-@interface RTCRtpSender : NSObject <RTCRtpSender>
+@interface RTCRtpReceiver : NSObject <RTCRtpReceiver>
- (instancetype)init NS_UNAVAILABLE;

Powered by Google App Engine
This is Rietveld 408576698