Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: webrtc/api/rtpsenderreceiver_unittest.cc

Issue 1917193008: Adding getParameters/setParameters APIs to RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding nil check and removing unneeded methods. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 MOCK_METHOD2(SetAudioPlayout, 48 MOCK_METHOD2(SetAudioPlayout,
49 void(uint32_t ssrc, 49 void(uint32_t ssrc,
50 bool enable)); 50 bool enable));
51 MOCK_METHOD4(SetAudioSend, 51 MOCK_METHOD4(SetAudioSend,
52 void(uint32_t ssrc, 52 void(uint32_t ssrc,
53 bool enable, 53 bool enable,
54 const cricket::AudioOptions& options, 54 const cricket::AudioOptions& options,
55 cricket::AudioSource* source)); 55 cricket::AudioSource* source));
56 MOCK_METHOD2(SetAudioPlayoutVolume, void(uint32_t ssrc, double volume)); 56 MOCK_METHOD2(SetAudioPlayoutVolume, void(uint32_t ssrc, double volume));
57 MOCK_CONST_METHOD1(GetAudioRtpParameters, RtpParameters(uint32_t ssrc)); 57 MOCK_CONST_METHOD1(GetAudioRtpSendParameters, RtpParameters(uint32_t ssrc));
58 MOCK_METHOD2(SetAudioRtpParameters, 58 MOCK_METHOD2(SetAudioRtpSendParameters,
59 bool(uint32_t ssrc, const RtpParameters&));
60 MOCK_CONST_METHOD1(GetAudioRtpReceiveParameters,
61 RtpParameters(uint32_t ssrc));
62 MOCK_METHOD2(SetAudioRtpReceiveParameters,
59 bool(uint32_t ssrc, const RtpParameters&)); 63 bool(uint32_t ssrc, const RtpParameters&));
60 64
61 void SetRawAudioSink(uint32_t, 65 void SetRawAudioSink(uint32_t,
62 std::unique_ptr<AudioSinkInterface> sink) override { 66 std::unique_ptr<AudioSinkInterface> sink) override {
63 sink_ = std::move(sink); 67 sink_ = std::move(sink);
64 } 68 }
65 69
66 private: 70 private:
67 std::unique_ptr<AudioSinkInterface> sink_; 71 std::unique_ptr<AudioSinkInterface> sink_;
68 }; 72 };
69 73
70 // Helper class to test RtpSender/RtpReceiver. 74 // Helper class to test RtpSender/RtpReceiver.
71 class MockVideoProvider : public VideoProviderInterface { 75 class MockVideoProvider : public VideoProviderInterface {
72 public: 76 public:
73 virtual ~MockVideoProvider() {} 77 virtual ~MockVideoProvider() {}
74 MOCK_METHOD2(SetSource, 78 MOCK_METHOD2(SetSource,
75 bool(uint32_t ssrc, 79 bool(uint32_t ssrc,
76 rtc::VideoSourceInterface<cricket::VideoFrame>* source)); 80 rtc::VideoSourceInterface<cricket::VideoFrame>* source));
77 MOCK_METHOD3(SetVideoPlayout, 81 MOCK_METHOD3(SetVideoPlayout,
78 void(uint32_t ssrc, 82 void(uint32_t ssrc,
79 bool enable, 83 bool enable,
80 rtc::VideoSinkInterface<cricket::VideoFrame>* sink)); 84 rtc::VideoSinkInterface<cricket::VideoFrame>* sink));
81 MOCK_METHOD3(SetVideoSend, 85 MOCK_METHOD3(SetVideoSend,
82 void(uint32_t ssrc, 86 void(uint32_t ssrc,
83 bool enable, 87 bool enable,
84 const cricket::VideoOptions* options)); 88 const cricket::VideoOptions* options));
85 89
86 MOCK_CONST_METHOD1(GetVideoRtpParameters, RtpParameters(uint32_t ssrc)); 90 MOCK_CONST_METHOD1(GetVideoRtpSendParameters, RtpParameters(uint32_t ssrc));
87 MOCK_METHOD2(SetVideoRtpParameters, 91 MOCK_METHOD2(SetVideoRtpSendParameters,
92 bool(uint32_t ssrc, const RtpParameters&));
93 MOCK_CONST_METHOD1(GetVideoRtpReceiveParameters,
94 RtpParameters(uint32_t ssrc));
95 MOCK_METHOD2(SetVideoRtpReceiveParameters,
88 bool(uint32_t ssrc, const RtpParameters&)); 96 bool(uint32_t ssrc, const RtpParameters&));
89 }; 97 };
90 98
91 class RtpSenderReceiverTest : public testing::Test { 99 class RtpSenderReceiverTest : public testing::Test {
92 public: 100 public:
93 virtual void SetUp() { 101 virtual void SetUp() {
94 stream_ = MediaStream::Create(kStreamLabel1); 102 stream_ = MediaStream::Create(kStreamLabel1);
95 } 103 }
96 104
97 void AddVideoTrack() { 105 void AddVideoTrack() {
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 sender->SetSsrc(kVideoSsrc2); 482 sender->SetSsrc(kVideoSsrc2);
475 483
476 // Calls expected from destructor. 484 // Calls expected from destructor.
477 EXPECT_CALL(video_provider_, SetSource(kVideoSsrc2, nullptr)).Times(1); 485 EXPECT_CALL(video_provider_, SetSource(kVideoSsrc2, nullptr)).Times(1);
478 EXPECT_CALL(video_provider_, SetVideoSend(kVideoSsrc2, false, _)).Times(1); 486 EXPECT_CALL(video_provider_, SetVideoSend(kVideoSsrc2, false, _)).Times(1);
479 } 487 }
480 488
481 TEST_F(RtpSenderReceiverTest, AudioSenderCanSetParameters) { 489 TEST_F(RtpSenderReceiverTest, AudioSenderCanSetParameters) {
482 CreateAudioRtpSender(); 490 CreateAudioRtpSender();
483 491
484 EXPECT_CALL(audio_provider_, GetAudioRtpParameters(kAudioSsrc)) 492 EXPECT_CALL(audio_provider_, GetAudioRtpSendParameters(kAudioSsrc))
485 .WillOnce(Return(RtpParameters())); 493 .WillOnce(Return(RtpParameters()));
486 EXPECT_CALL(audio_provider_, SetAudioRtpParameters(kAudioSsrc, _)) 494 EXPECT_CALL(audio_provider_, SetAudioRtpSendParameters(kAudioSsrc, _))
487 .WillOnce(Return(true)); 495 .WillOnce(Return(true));
488 RtpParameters params = audio_rtp_sender_->GetParameters(); 496 RtpParameters params = audio_rtp_sender_->GetParameters();
489 EXPECT_TRUE(audio_rtp_sender_->SetParameters(params)); 497 EXPECT_TRUE(audio_rtp_sender_->SetParameters(params));
490 498
491 DestroyAudioRtpSender(); 499 DestroyAudioRtpSender();
492 } 500 }
493 501
494 TEST_F(RtpSenderReceiverTest, VideoSenderCanSetParameters) { 502 TEST_F(RtpSenderReceiverTest, VideoSenderCanSetParameters) {
495 CreateVideoRtpSender(); 503 CreateVideoRtpSender();
496 504
497 EXPECT_CALL(video_provider_, GetVideoRtpParameters(kVideoSsrc)) 505 EXPECT_CALL(video_provider_, GetVideoRtpSendParameters(kVideoSsrc))
498 .WillOnce(Return(RtpParameters())); 506 .WillOnce(Return(RtpParameters()));
499 EXPECT_CALL(video_provider_, SetVideoRtpParameters(kVideoSsrc, _)) 507 EXPECT_CALL(video_provider_, SetVideoRtpSendParameters(kVideoSsrc, _))
500 .WillOnce(Return(true)); 508 .WillOnce(Return(true));
501 RtpParameters params = video_rtp_sender_->GetParameters(); 509 RtpParameters params = video_rtp_sender_->GetParameters();
502 EXPECT_TRUE(video_rtp_sender_->SetParameters(params)); 510 EXPECT_TRUE(video_rtp_sender_->SetParameters(params));
503 511
504 DestroyVideoRtpSender(); 512 DestroyVideoRtpSender();
505 } 513 }
506 514
515 TEST_F(RtpSenderReceiverTest, AudioReceiverCanSetParameters) {
516 CreateAudioRtpReceiver();
517
518 EXPECT_CALL(audio_provider_, GetAudioRtpReceiveParameters(kAudioSsrc))
519 .WillOnce(Return(RtpParameters()));
520 EXPECT_CALL(audio_provider_, SetAudioRtpReceiveParameters(kAudioSsrc, _))
521 .WillOnce(Return(true));
522 RtpParameters params = audio_rtp_receiver_->GetParameters();
523 EXPECT_TRUE(audio_rtp_receiver_->SetParameters(params));
524
525 DestroyAudioRtpReceiver();
526 }
527
528 TEST_F(RtpSenderReceiverTest, VideoReceiverCanSetParameters) {
529 CreateVideoRtpReceiver();
530
531 EXPECT_CALL(video_provider_, GetVideoRtpReceiveParameters(kVideoSsrc))
532 .WillOnce(Return(RtpParameters()));
533 EXPECT_CALL(video_provider_, SetVideoRtpReceiveParameters(kVideoSsrc, _))
534 .WillOnce(Return(true));
535 RtpParameters params = video_rtp_receiver_->GetParameters();
536 EXPECT_TRUE(video_rtp_receiver_->SetParameters(params));
537
538 DestroyVideoRtpReceiver();
539 }
540
507 } // namespace webrtc 541 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698