Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: webrtc/modules/audio_coding/audio_coding.gypi

Issue 1917163002: New interface (AudioDecoderFactory), with an implementation (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_coding.gypi
diff --git a/webrtc/modules/audio_coding/audio_coding.gypi b/webrtc/modules/audio_coding/audio_coding.gypi
index e460853ac10b4b9fbc84bedb4c3a95966dac35ac..e4ae2418e666a8aaed05b40326faa2deb32b314e 100644
--- a/webrtc/modules/audio_coding/audio_coding.gypi
+++ b/webrtc/modules/audio_coding/audio_coding.gypi
@@ -69,6 +69,50 @@
},
'targets': [
{
+ 'target_name': 'audio_codec_factory_interface',
hlundin-webrtc 2016/04/27 14:35:56 I assume you are intending to extend this target (
kwiberg-webrtc 2016/04/28 12:35:51 Yes, that was my plan. But perhaps it's better to
+ 'type': 'static_library',
+ 'dependencies': [
+ '<(webrtc_root)/common.gyp:webrtc_common',
+ ],
+ 'include_dirs': [
+ '<(webrtc_root)',
+ ],
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ '<(webrtc_root)',
+ ],
+ },
+ 'sources': [
+ 'codecs/audio_decoder_factory.h',
+ 'codecs/audio_format.cc',
+ 'codecs/audio_format.h',
+ ],
+ },
+ {
+ 'target_name': 'builtin_audio_codec_factory',
the sun 2016/04/27 20:34:14 _factories?
kwiberg-webrtc 2016/04/28 12:35:51 I'll change codec to decoder instead; see previous
+ 'type': 'static_library',
+ 'defines': [
+ '<@(audio_codec_defines)',
+ ],
+ 'dependencies': [
+ '<(webrtc_root)/common.gyp:webrtc_common',
+ '<@(audio_codec_dependencies)',
+ 'audio_codec_factory_interface',
+ ],
+ 'include_dirs': [
+ '<(webrtc_root)',
+ ],
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ '<(webrtc_root)',
+ ],
+ },
+ 'sources': [
+ 'codecs/builtin_audio_decoder_factory.cc',
+ 'codecs/builtin_audio_decoder_factory.h',
+ ],
+ },
+ {
'target_name': 'rent_a_codec',
'type': 'static_library',
'defines': [

Powered by Google App Engine
This is Rietveld 408576698