Remove VCMQmRobustness.

Remove VCMQmRobustness.

Class contained a lot of not-really-wired-up functionality that ended up
being complicated ways of saying return 1; or return false;. This
removes this dependency that complicates code readability significantly.

BUG=webrtc:5066
R=marpan@google.com, marpan@webrtc.org
TBR=stefan@webrtc.org

Committed: https://crrev.com/73894369791cb5eedc8788baf918ec07d11d351d
Cr-Commit-Position: refs/heads/master@{#12516}

[pbos-webrtc, 2016-04-26 14:43:37]

PTAL,

AdjustFecFactor() would always return 1.0, SetUepProtection would always return
false, so I've inlined that behavior and then cleaned up and removed some code.

Unless you guys think there'll be a follow-up that makes use of this code I
think it makes sense to delete it. What do you think?

[marpan, 2016-04-26 21:21:02]

marpan@google.com changed reviewers:
+ marpan@google.com

[marpan, 2016-04-26 21:21:03]

lgtm

[pbos-webrtc, 2016-04-26 21:44:44]

Description was changed from

==========
Remove VCMQmRobustness.

Class contained a lot of not-really-wired-up functionality that ended up
being complicated ways of saying return 1; or return false;. This
removes this dependency that complicates code readability significantly.

BUG=webrtc:5066
R=marpan@webrtc.org, stefan@webrtc.org
==========

to

==========
Remove VCMQmRobustness.

Class contained a lot of not-really-wired-up functionality that ended up
being complicated ways of saying return 1; or return false;. This
removes this dependency that complicates code readability significantly.

BUG=webrtc:5066
R=marpan@webrtc.org
TBR=stefan@webrtc.org
==========

[pbos-webrtc, 2016-04-26 21:54:46]

Description was changed from

==========
Remove VCMQmRobustness.

Class contained a lot of not-really-wired-up functionality that ended up
being complicated ways of saying return 1; or return false;. This
removes this dependency that complicates code readability significantly.

BUG=webrtc:5066
R=marpan@webrtc.org
TBR=stefan@webrtc.org
==========

to

==========
Remove VCMQmRobustness.

Class contained a lot of not-really-wired-up functionality that ended up
being complicated ways of saying return 1; or return false;. This
removes this dependency that complicates code readability significantly.

BUG=webrtc:5066
R=marpan@google.com, marpan@webrtc.org
TBR=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/73894369791cb5eedc8788baf...
==========

[pbos-webrtc, 2016-04-26 21:54:48]

Committed patchset #1 (id:1) manually as
73894369791cb5eedc8788baf918ec07d11d351d (presubmit successful).

[commit-bot: I haz the power, 2016-04-26 21:54:49]

Description was changed from

==========
Remove VCMQmRobustness.

Class contained a lot of not-really-wired-up functionality that ended up
being complicated ways of saying return 1; or return false;. This
removes this dependency that complicates code readability significantly.

BUG=webrtc:5066
R=marpan@google.com, marpan@webrtc.org
TBR=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/73894369791cb5eedc8788baf...
==========

to

==========
Remove VCMQmRobustness.

Class contained a lot of not-really-wired-up functionality that ended up
being complicated ways of saying return 1; or return false;. This
removes this dependency that complicates code readability significantly.

BUG=webrtc:5066
R=marpan@google.com, marpan@webrtc.org
TBR=stefan@webrtc.org

Committed: https://crrev.com/73894369791cb5eedc8788baf918ec07d11d351d
Cr-Commit-Position: refs/heads/master@{#12516}
==========

[commit-bot: I haz the power, 2016-04-26 21:54:50]

Patchset 1 (id:??) landed as
https://crrev.com/73894369791cb5eedc8788baf918ec07d11d351d
Cr-Commit-Position: refs/heads/master@{#12516}

[stefan-webrtc, 2016-04-27 08:29:32]

What was the purpose of AdjustFecFactor, and why didn't it do anything? Are we
sure it's not something we want?

[stefan-webrtc, 2016-04-27 08:40:03]

On 2016/04/27 08:29:32, stefan-webrtc (holmer) wrote:
> What was the purpose of AdjustFecFactor, and why didn't it do anything? Are we
> sure it's not something we want?

Ok I see now that it didn't do anything at all.

[pbos-webrtc, 2016-04-29 21:29:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1935753002/ by pbos@webrtc.org.

The reason for reverting is: Speculative revert for perf regression..