Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1916953002: Add proper dependencies for webrtc/modules/audio_coding/codecs (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add proper dependencies for webrtc/modules/audio_coding/codecs The audio_decoder_interface and audio_encoder_interface targets are depending on rtc_base_approved headers but don't declare such dependencies. NOTRY=True Committed: https://crrev.com/4e7f6c188770765f4dff52d31fb77a6630a51b80 Cr-Commit-Position: refs/heads/master@{#12500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/interfaces.gypi View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
4 years, 8 months ago (2016-04-25 20:17:52 UTC) #3
kwiberg-webrtc
lgtm
4 years, 8 months ago (2016-04-25 21:09:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916953002/1
4 years, 8 months ago (2016-04-26 04:58:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 04:59:54 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 05:00:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e7f6c188770765f4dff52d31fb77a6630a51b80
Cr-Commit-Position: refs/heads/master@{#12500}

Powered by Google App Engine
This is Rietveld 408576698