Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1916373002: Add missing include to x11windowpicker.cc (Closed)

Created:
4 years, 7 months ago by joachim
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add missing include to x11windowpicker.cc Before https://codereview.webrtc.org/1920043002/ this was pulled in implicitly by "scoped_ptr.h". Committed: https://crrev.com/b67aba81e5ec2dc52e205dee0bf8c23857849dfe Cr-Commit-Position: refs/heads/master@{#12505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/base/x11windowpicker.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
joachim
Ptal, this should fix the compile error when rolling into Chromium, introduced by https://codereview.webrtc.org/1920043002/ Compile ...
4 years, 7 months ago (2016-04-26 10:30:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916373002/1
4 years, 7 months ago (2016-04-26 10:35:44 UTC) #4
tommi
lgtm
4 years, 7 months ago (2016-04-26 10:54:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 11:33:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916373002/1
4 years, 7 months ago (2016-04-26 11:44:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 11:54:03 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 11:54:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b67aba81e5ec2dc52e205dee0bf8c23857849dfe
Cr-Commit-Position: refs/heads/master@{#12505}

Powered by Google App Engine
This is Rietveld 408576698