Deliver reordered packets in arrival time order after parsing feedback message.

Deliver reordered packets in arrival time order after parsing feedback message.

This is what the remote bitrate estimator expects.

BUG=5823
R=sprang@webrtc.org

Committed: https://crrev.com/ed9535e2cac6be7a45fb03dc8426ef3b0ec43294
Cr-Commit-Position: refs/heads/master@{#12527}

[stefan-webrtc, 2016-04-25 15:07:03]

Description was changed from

==========
Deliver reordered packets in arrival time order.

BUG=5823
==========

to

==========
Deliver reordered packets in arrival time order after parsing feedback message.

This is what the remote bitrate estimator expects.

BUG=5823
==========

[stefan-webrtc, 2016-04-25 15:07:13]

stefan@webrtc.org changed reviewers:
+ sprang@webrtc.org

[stefan-webrtc, 2016-04-25 15:07:21]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 15:07:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915993002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915993002/1

[commit-bot: I haz the power, 2016-04-25 17:08:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 17:08:13]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2016-04-27 07:38:31]

ping

[sprang_webrtc, 2016-04-27 09:05:17]

lgtm with nit

https://codereview.webrtc.org/1915993002/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc
(right):

https://codereview.webrtc.org/1915993002/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc:38: return
lhs.arrival_time_ms < rhs.arrival_time_ms;
Can you restructure this to avoid nesting?
eg

if (lhs.arrival_time_ms != rhs.arrival_time_ms)
  return lhs.arrival_time_ms < rhs.arrival_time_ms;
if (lhs.send_time_ms == rhs.send_time_ms)
  return lhs.send_time_ms < rhs.send_time_ms;
return lhs.sequence_number < rhs.sequence_number;

[stefan-webrtc, 2016-04-27 12:21:31]

Description was changed from

==========
Deliver reordered packets in arrival time order after parsing feedback message.

This is what the remote bitrate estimator expects.

BUG=5823
==========

to

==========
Deliver reordered packets in arrival time order after parsing feedback message.

This is what the remote bitrate estimator expects.

BUG=5823
R=sprang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ed9535e2cac6be7a45fb03dc8...
==========

[stefan-webrtc, 2016-04-27 12:21:33]

Committed patchset #2 (id:20001) manually as
ed9535e2cac6be7a45fb03dc8426ef3b0ec43294 (presubmit successful).

[commit-bot: I haz the power, 2016-04-27 12:21:35]

Description was changed from

==========
Deliver reordered packets in arrival time order after parsing feedback message.

This is what the remote bitrate estimator expects.

BUG=5823
R=sprang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ed9535e2cac6be7a45fb03dc8...
==========

to

==========
Deliver reordered packets in arrival time order after parsing feedback message.

This is what the remote bitrate estimator expects.

BUG=5823
R=sprang@webrtc.org

Committed: https://crrev.com/ed9535e2cac6be7a45fb03dc8426ef3b0ec43294
Cr-Commit-Position: refs/heads/master@{#12527}
==========

[commit-bot: I haz the power, 2016-04-27 12:21:37]

Patchset 2 (id:??) landed as
https://crrev.com/ed9535e2cac6be7a45fb03dc8426ef3b0ec43294
Cr-Commit-Position: refs/heads/master@{#12527}

[stefan-webrtc, 2016-04-27 12:30:13]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1928443004/ by stefan@webrtc.org.

The reason for reverting is: Breaks bots.

[kjellander_webrtc, 2016-04-27 12:44:44]

On 2016/04/27 12:30:13, stefan-webrtc (holmer) wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.webrtc.org/1928443004/ by mailto:stefan@webrtc.org.
> 
> The reason for reverting is: Breaks bots.

Ooops ;)