Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1915973002: Revert of Enable video processing unittest to take video clips as param. (Closed)

Created:
4 years, 8 months ago by terelius
Modified:
4 years, 7 months ago
Reviewers:
jackychen_, marpan2
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable video processing unittest to take video clips as param. (patchset #1 id:1 of https://codereview.webrtc.org/1907353004/ ) Reason for revert: Candidate culprit CL for breaking the gtest initialization on DrMemory. Original issue's description: > Enable video processing unittest to take video clips as param. > > This change enables video processing unittest (including all tests under > it, e.g. denoiser test) to use a set of video clips as param, which is > important if we want to do a regression test on the visual quality > offline. > > BUG= > > Committed: https://crrev.com/6d94e5224a3d3b1a6d66a428dbe75af7106e8d60 > Cr-Commit-Position: refs/heads/master@{#12485} TBR=marpan@webrtc.org,jackychen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f55f58d45d25497169ba4eeb44ce6c6112b940d2 Cr-Commit-Position: refs/heads/master@{#12490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -52 lines) Patch
M webrtc/modules/video_processing/test/brightness_detection_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/test/content_metrics_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/deflickering_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/denoiser_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.h View 1 chunk +13 lines, -14 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 9 chunks +25 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
terelius
Created Revert of Enable video processing unittest to take video clips as param.
4 years, 8 months ago (2016-04-25 14:36:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915973002/1
4 years, 8 months ago (2016-04-25 14:36:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 14:36:55 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:37:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f55f58d45d25497169ba4eeb44ce6c6112b940d2
Cr-Commit-Position: refs/heads/master@{#12490}

Powered by Google App Engine
This is Rietveld 408576698