Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915853003: WebRtcVideoFrameFactoryTest shouldn't inherit VideoFrameTest. (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcVideoFrameFactoryTest shouldn't inherit VideoFrameTest. BUG= Committed: https://crrev.com/06f7e49438dca7446db02daeaa596772e4be20f8 Cr-Commit-Position: refs/heads/master@{#12523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/media/engine/webrtcvideoframefactory_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
PTAL. This inheritance makes no sense.
4 years, 8 months ago (2016-04-25 14:14:42 UTC) #2
perkj_webrtc
lgtm
4 years, 8 months ago (2016-04-27 05:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915853003/1
4 years, 8 months ago (2016-04-27 06:52:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 08:37:56 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 08:38:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/06f7e49438dca7446db02daeaa596772e4be20f8
Cr-Commit-Position: refs/heads/master@{#12523}

Powered by Google App Engine
This is Rietveld 408576698