Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: webrtc/modules/audio_processing/audio_processing_unittest.cc

Issue 1915813002: Disable failing modules_unittests for UBSan. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/audio_processing_unittest.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_unittest.cc b/webrtc/modules/audio_processing/audio_processing_unittest.cc
index ded75c8652079e4c2a523f98a5f2ace80c1d0ce3..a5b293eb1820b569ee4f88fb191696209586f7d0 100644
--- a/webrtc/modules/audio_processing/audio_processing_unittest.cc
+++ b/webrtc/modules/audio_processing/audio_processing_unittest.cc
@@ -1847,17 +1847,35 @@ void ApmTest::VerifyDebugDumpTest(Format format) {
remove(limited_filename.c_str());
}
-TEST_F(ApmTest, VerifyDebugDumpInt) {
+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
+#ifdef UNDEFINED_SANITIZER
+#define MAYBE_VerifyDebugDumpInt DISABLED_VerifyDebugDumpInt
+#else
+#define MAYBE_VerifyDebugDumpInt VerifyDebugDumpInt
+#endif
+TEST_F(ApmTest, MAYBE_VerifyDebugDumpInt) {
VerifyDebugDumpTest(kIntFormat);
}
-TEST_F(ApmTest, VerifyDebugDumpFloat) {
+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
+#ifdef UNDEFINED_SANITIZER
+#define MAYBE_VerifyDebugDumpFloat DISABLED_VerifyDebugDumpFloat
+#else
+#define MAYBE_VerifyDebugDumpFloat VerifyDebugDumpFloat
+#endif
+TEST_F(ApmTest, MAYBE_VerifyDebugDumpFloat) {
VerifyDebugDumpTest(kFloatFormat);
}
#endif
// TODO(andrew): expand test to verify output.
-TEST_F(ApmTest, DebugDump) {
+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
+#ifdef UNDEFINED_SANITIZER
+#define MAYBE_DebugDump DISABLED_DebugDump
+#else
+#define MAYBE_DebugDump DebugDump
+#endif
+TEST_F(ApmTest, MAYBE_DebugDump) {
const std::string filename =
test::TempFilename(test::OutputPath(), "debug_aec");
EXPECT_EQ(apm_->kNullPointerError,
@@ -1890,7 +1908,13 @@ TEST_F(ApmTest, DebugDump) {
}
// TODO(andrew): expand test to verify output.
-TEST_F(ApmTest, DebugDumpFromFileHandle) {
+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
+#ifdef UNDEFINED_SANITIZER
+#define MAYBE_DebugDumpFromFileHandle DISABLED_DebugDumpFromFileHandle
+#else
+#define MAYBE_DebugDumpFromFileHandle DebugDumpFromFileHandle
+#endif
+TEST_F(ApmTest, MAYBE_DebugDumpFromFileHandle) {
FILE* fid = NULL;
EXPECT_EQ(apm_->kNullPointerError, apm_->StartDebugRecording(fid, -1));
const std::string filename =
« no previous file with comments | « webrtc/modules/audio_coding/neteq/neteq_unittest.cc ('k') | webrtc/modules/audio_processing/test/debug_dump_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698