Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915813002: Disable failing modules_unittests for UBSan. (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable failing modules_unittests for UBSan. BUG=webrtc:5820 TBR=pbos@webrtc.org Committed: https://crrev.com/c23bf2e54d922486254cdd7657aafceaa958ce25 Cr-Commit-Position: refs/heads/master@{#12482}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 2 chunks +28 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
4 years, 8 months ago (2016-04-25 04:42:15 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:40001) manually as c23bf2e54d922486254cdd7657aafceaa958ce25 (presubmit successful).
4 years, 8 months ago (2016-04-25 04:43:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c23bf2e54d922486254cdd7657aafceaa958ce25 Cr-Commit-Position: refs/heads/master@{#12482}
4 years, 8 months ago (2016-04-25 04:43:30 UTC) #7
pbos-webrtc
lgtm
4 years, 7 months ago (2016-04-25 12:16:07 UTC) #8
pbos-webrtc
4 years, 7 months ago (2016-05-02 16:23:10 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.webrtc.org/1937153002/ by pbos@webrtc.org.

The reason for reverting is: Fix upstream should've landed in our repository..

Powered by Google App Engine
This is Rietveld 408576698