Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webrtc/test/histogram.cc

Issue 1915523002: Add a default implementation in metrics_default.cc of histograms methods in system_wrappers/interfac (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/histogram.h ('k') | webrtc/test/test.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/histogram.cc
diff --git a/webrtc/test/histogram.cc b/webrtc/test/histogram.cc
deleted file mode 100644
index 2893e4389ad61c7c79980d979f06d78fa02ed4b7..0000000000000000000000000000000000000000
--- a/webrtc/test/histogram.cc
+++ /dev/null
@@ -1,97 +0,0 @@
-/*
- * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include "webrtc/test/histogram.h"
-
-#include <map>
-
-#include "webrtc/base/checks.h"
-#include "webrtc/base/criticalsection.h"
-#include "webrtc/base/thread_annotations.h"
-#include "webrtc/system_wrappers/include/metrics.h"
-
-// Test implementation of histogram methods in
-// webrtc/system_wrappers/include/metrics.h.
-
-namespace webrtc {
-namespace {
-struct SampleInfo {
- SampleInfo(const std::string& name) : name_(name), last_(-1), total_(0) {}
- const std::string name_;
- int last_; // Last added sample.
- int total_; // Total number of added samples.
-};
-
-rtc::CriticalSection histogram_crit_;
-// Map holding info about added samples to a histogram (mapped by the histogram
-// name).
-std::map<std::string, SampleInfo> histograms_ GUARDED_BY(histogram_crit_);
-} // namespace
-
-namespace metrics {
-Histogram* HistogramFactoryGetCounts(const std::string& name, int min, int max,
- int bucket_count) {
- rtc::CritScope cs(&histogram_crit_);
- if (histograms_.find(name) == histograms_.end()) {
- histograms_.insert(std::make_pair(name, SampleInfo(name)));
- }
- auto it = histograms_.find(name);
- return reinterpret_cast<Histogram*>(&it->second);
-}
-
-Histogram* HistogramFactoryGetEnumeration(const std::string& name,
- int boundary) {
- rtc::CritScope cs(&histogram_crit_);
- if (histograms_.find(name) == histograms_.end()) {
- histograms_.insert(std::make_pair(name, SampleInfo(name)));
- }
- auto it = histograms_.find(name);
- return reinterpret_cast<Histogram*>(&it->second);
-}
-
-void HistogramAdd(
- Histogram* histogram_pointer, const std::string& name, int sample) {
- rtc::CritScope cs(&histogram_crit_);
- SampleInfo* ptr = reinterpret_cast<SampleInfo*>(histogram_pointer);
- // The name should not vary.
- RTC_CHECK(ptr->name_ == name);
- ptr->last_ = sample;
- ++ptr->total_;
-}
-} // namespace metrics
-
-namespace test {
-int LastHistogramSample(const std::string& name) {
- rtc::CritScope cs(&histogram_crit_);
- const auto it = histograms_.find(name);
- if (it == histograms_.end()) {
- return -1;
- }
- return it->second.last_;
-}
-
-int NumHistogramSamples(const std::string& name) {
- rtc::CritScope cs(&histogram_crit_);
- const auto it = histograms_.find(name);
- if (it == histograms_.end()) {
- return 0;
- }
- return it->second.total_;
-}
-
-void ClearHistograms() {
- rtc::CritScope cs(&histogram_crit_);
- for (auto& it : histograms_) {
- it.second.last_ = -1;
- it.second.total_ = 0;
- }
-}
-} // namespace test
-} // namespace webrtc
« no previous file with comments | « webrtc/test/histogram.h ('k') | webrtc/test/test.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698