Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: webrtc/system_wrappers/source/metrics_default_unittest.cc

Issue 1915523002: Add a default implementation in metrics_default.cc of histograms methods in system_wrappers/interfac (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 #include "webrtc/system_wrappers/include/metrics.h"
14 #include "webrtc/system_wrappers/include/metrics_default.h"
15
16 namespace webrtc {
17
18 namespace {
19 const int kSample = 22;
20 const std::string kName = "Name";
21
22 int NumSamples(
23 const std::string& name,
24 const std::map<std::string, std::unique_ptr<metrics::SampleInfo>>&
25 histograms) {
26 const auto it = histograms.find(name);
27 if (it == histograms.end())
28 return 0;
29
30 int num_samples = 0;
31 for (const auto& sample : it->second->samples)
32 num_samples += sample.second;
33
34 return num_samples;
35 }
36
37 int NumEvents(const std::string& name,
38 int sample,
39 const std::map<std::string, std::unique_ptr<metrics::SampleInfo>>&
40 histograms) {
41 const auto it = histograms.find(name);
42 if (it == histograms.end())
43 return 0;
44
45 const auto it_sample = it->second->samples.find(sample);
46 if (it_sample == it->second->samples.end())
47 return 0;
48
49 return it_sample->second;
50 }
51 } // namespace
52
53 class MetricsDefaultTest : public ::testing::Test {
54 public:
55 MetricsDefaultTest() {}
56
57 protected:
58 virtual void SetUp() {
59 metrics::Reset();
60 metrics::Enable();
61 }
62 };
63
64 TEST_F(MetricsDefaultTest, Reset) {
65 RTC_HISTOGRAM_PERCENTAGE(kName, kSample);
66 EXPECT_EQ(1, metrics::NumSamples(kName));
67 metrics::Reset();
68 EXPECT_EQ(0, metrics::NumSamples(kName));
69 }
70
71 TEST_F(MetricsDefaultTest, NumHistogramSamples) {
72 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
73 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
74 RTC_HISTOGRAM_PERCENTAGE(kName, 10);
75 EXPECT_EQ(3, metrics::NumSamples(kName));
76 EXPECT_EQ(0, metrics::NumSamples("NonExisting"));
77 }
78
79 TEST_F(MetricsDefaultTest, NumSampleEvents) {
80 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
81 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
82 RTC_HISTOGRAM_PERCENTAGE(kName, 10);
83 EXPECT_EQ(2, metrics::NumEvents(kName, 5));
84 EXPECT_EQ(1, metrics::NumEvents(kName, 10));
85 EXPECT_EQ(0, metrics::NumEvents(kName, 11));
86 EXPECT_EQ(0, metrics::NumEvents("NonExisting", 5));
87 }
88
89 TEST_F(MetricsDefaultTest, MinHistogramSample) {
90 RTC_HISTOGRAM_PERCENTAGE(kName, kSample);
91 RTC_HISTOGRAM_PERCENTAGE(kName, kSample + 1);
92 EXPECT_EQ(kSample, metrics::MinSample(kName));
93 EXPECT_EQ(-1, metrics::MinSample("NonExisting"));
94 }
95
96 TEST_F(MetricsDefaultTest, Overflow) {
97 const std::string kName = "Overflow";
98 // Samples should end up in overflow bucket.
99 RTC_HISTOGRAM_PERCENTAGE(kName, 101);
100 EXPECT_EQ(1, metrics::NumEvents(kName, 101));
101 EXPECT_EQ(1, metrics::NumSamples(kName));
102 RTC_HISTOGRAM_PERCENTAGE(kName, 102);
103 EXPECT_EQ(2, metrics::NumEvents(kName, 101));
104 EXPECT_EQ(2, metrics::NumSamples(kName));
105 }
106
107 TEST_F(MetricsDefaultTest, GetAndReset) {
108 RTC_HISTOGRAM_PERCENTAGE("Histogram1", 4);
109 RTC_HISTOGRAM_PERCENTAGE("Histogram1", 5);
110 RTC_HISTOGRAM_PERCENTAGE("Histogram1", 5);
111 RTC_HISTOGRAM_PERCENTAGE("Histogram2", 10);
112 EXPECT_EQ(3, metrics::NumSamples("Histogram1"));
113 EXPECT_EQ(1, metrics::NumSamples("Histogram2"));
114
115 std::map<std::string, std::unique_ptr<metrics::SampleInfo>> histograms;
116 metrics::GetAndReset(&histograms);
117 EXPECT_EQ(2u, histograms.size());
118 EXPECT_EQ(0, metrics::NumSamples("Histogram1"));
119 EXPECT_EQ(0, metrics::NumSamples("Histogram2"));
120
121 EXPECT_EQ(3, NumSamples("Histogram1", histograms));
122 EXPECT_EQ(1, NumSamples("Histogram2", histograms));
123 EXPECT_EQ(1, NumEvents("Histogram1", 4, histograms));
124 EXPECT_EQ(2, NumEvents("Histogram1", 5, histograms));
125 EXPECT_EQ(1, NumEvents("Histogram2", 10, histograms));
126 }
127
128 TEST_F(MetricsDefaultTest, TestMinMaxBucket) {
129 const std::string kName = "MinMaxCounts100";
130 RTC_HISTOGRAM_COUNTS_100(kName, 4);
131
132 std::map<std::string, std::unique_ptr<metrics::SampleInfo>> histograms;
133 metrics::GetAndReset(&histograms);
134 EXPECT_EQ(1u, histograms.size());
135 EXPECT_EQ(kName, histograms.begin()->second->name);
136 EXPECT_EQ(1, histograms.begin()->second->min);
137 EXPECT_EQ(100, histograms.begin()->second->max);
138 EXPECT_EQ(50, histograms.begin()->second->bucket_count);
139 EXPECT_EQ(1u, histograms.begin()->second->samples.size());
140 }
141
142 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698