Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: webrtc/video/call_stats_unittest.cc

Issue 1915523002: Add a default implementation in metrics_default.cc of histograms methods in system_wrappers/interfac (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/test/test_suite.cc ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <memory> 11 #include <memory>
12 12
13 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" 16 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
17 #include "webrtc/system_wrappers/include/metrics.h" 17 #include "webrtc/system_wrappers/include/metrics.h"
18 #include "webrtc/test/histogram.h" 18 #include "webrtc/system_wrappers/include/metrics_default.h"
19 #include "webrtc/video/call_stats.h" 19 #include "webrtc/video/call_stats.h"
20 20
21 using ::testing::_; 21 using ::testing::_;
22 using ::testing::AnyNumber; 22 using ::testing::AnyNumber;
23 using ::testing::Return; 23 using ::testing::Return;
24 24
25 namespace webrtc { 25 namespace webrtc {
26 26
27 class MockStatsObserver : public CallStatsObserver { 27 class MockStatsObserver : public CallStatsObserver {
28 public: 28 public:
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 rtcp_rtt_stats->OnRttUpdate(kRttLow); 197 rtcp_rtt_stats->OnRttUpdate(kRttLow);
198 rtcp_rtt_stats->OnRttUpdate(kRttHigh); 198 rtcp_rtt_stats->OnRttUpdate(kRttHigh);
199 EXPECT_CALL(stats_observer, OnRttUpdate(kAvgRtt, kRttHigh)).Times(1); 199 EXPECT_CALL(stats_observer, OnRttUpdate(kAvgRtt, kRttHigh)).Times(1);
200 call_stats_->Process(); 200 call_stats_->Process();
201 EXPECT_EQ(kAvgRtt, rtcp_rtt_stats->LastProcessedRtt()); 201 EXPECT_EQ(kAvgRtt, rtcp_rtt_stats->LastProcessedRtt());
202 202
203 call_stats_->DeregisterStatsObserver(&stats_observer); 203 call_stats_->DeregisterStatsObserver(&stats_observer);
204 } 204 }
205 205
206 TEST_F(CallStatsTest, ProducesHistogramMetrics) { 206 TEST_F(CallStatsTest, ProducesHistogramMetrics) {
207 metrics::Reset();
207 const int64_t kRtt = 123; 208 const int64_t kRtt = 123;
208 RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats(); 209 RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats();
209 rtcp_rtt_stats->OnRttUpdate(kRtt); 210 rtcp_rtt_stats->OnRttUpdate(kRtt);
210 fake_clock_.AdvanceTimeMilliseconds(metrics::kMinRunTimeInSeconds * 1000); 211 fake_clock_.AdvanceTimeMilliseconds(metrics::kMinRunTimeInSeconds * 1000);
211 rtcp_rtt_stats->OnRttUpdate(kRtt); 212 rtcp_rtt_stats->OnRttUpdate(kRtt);
212 call_stats_->Process(); 213 call_stats_->Process();
213 call_stats_.reset(); 214 call_stats_.reset();
214 215
215 EXPECT_EQ(1, test::NumHistogramSamples( 216 EXPECT_EQ(1, metrics::NumSamples(
216 "WebRTC.Video.AverageRoundTripTimeInMilliseconds")); 217 "WebRTC.Video.AverageRoundTripTimeInMilliseconds"));
217 EXPECT_EQ(kRtt, test::LastHistogramSample( 218 EXPECT_EQ(1, metrics::NumEvents(
218 "WebRTC.Video.AverageRoundTripTimeInMilliseconds")); 219 "WebRTC.Video.AverageRoundTripTimeInMilliseconds", kRtt));
219 } 220 }
220 221
221 } // namespace webrtc 222 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/test/test_suite.cc ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698