Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: webrtc/system_wrappers/source/metrics_default_unittest.cc

Issue 1915523002: Add a default implementation in metrics_default.cc of histograms methods in system_wrappers/interfac (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 #include "webrtc/system_wrappers/include/metrics.h"
14 #include "webrtc/system_wrappers/include/metrics_default.h"
15
16 namespace webrtc {
17
18 namespace {
19 const int kSample = 22;
20 const char kName[] = "Name";
21
22 int NumSamples(
23 const std::string& name,
24 const std::map<std::string, std::unique_ptr<metrics::SampleInfo>>&
25 histograms) {
26 const auto it = histograms.find(name);
27 if (it == histograms.end())
28 return 0;
29
30 int num_samples = 0;
31 for (const auto& sample : it->second->samples)
32 num_samples += sample.second;
33
34 return num_samples;
35 }
36
37 int NumEvents(const std::string& name,
38 int sample,
39 const std::map<std::string, std::unique_ptr<metrics::SampleInfo>>&
40 histograms) {
41 const auto it = histograms.find(name);
42 if (it == histograms.end())
43 return 0;
44
45 const auto it_sample = it->second->samples.find(sample);
46 if (it_sample == it->second->samples.end())
47 return 0;
48
49 return it_sample->second;
50 }
51 } // namespace
52
53 class MetricsDefaultTest : public ::testing::Test {
54 public:
55 MetricsDefaultTest() {}
56
57 protected:
58 virtual void SetUp() {
59 metrics::Reset();
60 }
61 };
62
63 TEST_F(MetricsDefaultTest, Reset) {
64 RTC_HISTOGRAM_PERCENTAGE(kName, kSample);
65 EXPECT_EQ(1, metrics::NumSamples(kName));
66 metrics::Reset();
67 EXPECT_EQ(0, metrics::NumSamples(kName));
68 }
69
70 TEST_F(MetricsDefaultTest, NumSamples) {
71 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
72 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
73 RTC_HISTOGRAM_PERCENTAGE(kName, 10);
74 EXPECT_EQ(3, metrics::NumSamples(kName));
75 EXPECT_EQ(0, metrics::NumSamples("NonExisting"));
76 }
77
78 TEST_F(MetricsDefaultTest, NumEvents) {
79 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
80 RTC_HISTOGRAM_PERCENTAGE(kName, 5);
81 RTC_HISTOGRAM_PERCENTAGE(kName, 10);
82 EXPECT_EQ(2, metrics::NumEvents(kName, 5));
83 EXPECT_EQ(1, metrics::NumEvents(kName, 10));
84 EXPECT_EQ(0, metrics::NumEvents(kName, 11));
85 EXPECT_EQ(0, metrics::NumEvents("NonExisting", 5));
86 }
87
88 TEST_F(MetricsDefaultTest, MinSample) {
89 RTC_HISTOGRAM_PERCENTAGE(kName, kSample);
90 RTC_HISTOGRAM_PERCENTAGE(kName, kSample + 1);
91 EXPECT_EQ(kSample, metrics::MinSample(kName));
92 EXPECT_EQ(-1, metrics::MinSample("NonExisting"));
93 }
94
95 TEST_F(MetricsDefaultTest, Overflow) {
96 const std::string kName = "Overflow";
97 // Samples should end up in overflow bucket.
98 RTC_HISTOGRAM_PERCENTAGE(kName, 101);
99 EXPECT_EQ(1, metrics::NumSamples(kName));
100 EXPECT_EQ(1, metrics::NumEvents(kName, 101));
101 RTC_HISTOGRAM_PERCENTAGE(kName, 102);
102 EXPECT_EQ(2, metrics::NumSamples(kName));
103 EXPECT_EQ(2, metrics::NumEvents(kName, 101));
104 }
105
106 TEST_F(MetricsDefaultTest, Underflow) {
107 const std::string kName = "Underflow";
108 // Samples should end up in underflow bucket.
109 RTC_HISTOGRAM_COUNTS_10000(kName, 0);
110 EXPECT_EQ(1, metrics::NumSamples(kName));
111 EXPECT_EQ(1, metrics::NumEvents(kName, 0));
112 RTC_HISTOGRAM_COUNTS_10000(kName, -1);
113 EXPECT_EQ(2, metrics::NumSamples(kName));
114 EXPECT_EQ(2, metrics::NumEvents(kName, 0));
115 }
116
117 TEST_F(MetricsDefaultTest, GetAndReset) {
118 std::map<std::string, std::unique_ptr<metrics::SampleInfo>> histograms;
119 metrics::GetAndReset(&histograms);
120 EXPECT_EQ(0u, histograms.size());
121 RTC_HISTOGRAM_PERCENTAGE("Histogram1", 4);
122 RTC_HISTOGRAM_PERCENTAGE("Histogram1", 5);
123 RTC_HISTOGRAM_PERCENTAGE("Histogram1", 5);
124 RTC_HISTOGRAM_PERCENTAGE("Histogram2", 10);
125 EXPECT_EQ(3, metrics::NumSamples("Histogram1"));
126 EXPECT_EQ(1, metrics::NumSamples("Histogram2"));
127
128 metrics::GetAndReset(&histograms);
129 EXPECT_EQ(2u, histograms.size());
130 EXPECT_EQ(0, metrics::NumSamples("Histogram1"));
131 EXPECT_EQ(0, metrics::NumSamples("Histogram2"));
132
133 EXPECT_EQ(3, NumSamples("Histogram1", histograms));
134 EXPECT_EQ(1, NumSamples("Histogram2", histograms));
135 EXPECT_EQ(1, NumEvents("Histogram1", 4, histograms));
136 EXPECT_EQ(2, NumEvents("Histogram1", 5, histograms));
137 EXPECT_EQ(1, NumEvents("Histogram2", 10, histograms));
138 }
139
140 TEST_F(MetricsDefaultTest, TestMinMaxBucket) {
141 const std::string kName = "MinMaxCounts100";
142 RTC_HISTOGRAM_COUNTS_100(kName, 4);
143
144 std::map<std::string, std::unique_ptr<metrics::SampleInfo>> histograms;
145 metrics::GetAndReset(&histograms);
146 EXPECT_EQ(1u, histograms.size());
147 EXPECT_EQ(kName, histograms.begin()->second->name);
148 EXPECT_EQ(1, histograms.begin()->second->min);
149 EXPECT_EQ(100, histograms.begin()->second->max);
150 EXPECT_EQ(50u, histograms.begin()->second->bucket_count);
151 EXPECT_EQ(1u, histograms.begin()->second->samples.size());
152 }
153
154 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/system_wrappers/source/metrics_default.cc ('k') | webrtc/system_wrappers/source/metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698