Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1914893005: Move BitrateAdjuster into common_video (Closed)

Created:
4 years, 8 months ago by emircan
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, pbos-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move BitrateAdjuster into common_video This CL moves BitrateAdjuster into common_video folder as it was suggested on [0] such that it can be properly linked with Chrome projects. [0] https://codereview.chromium.org/1818903004/ BUG=500605 Committed: https://crrev.com/55a401e607dfdca2f40c7b912c11a9c7e6b10f86 Cr-Commit-Position: refs/heads/master@{#12515}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -428 lines) Patch
M webrtc/common_video/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + webrtc/common_video/bitrate_adjuster.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/common_video/bitrate_adjuster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/common_video.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_video/common_video_unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/common_video/include/bitrate_adjuster.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/video_coding/bitrate_adjuster.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D webrtc/modules/video_coding/bitrate_adjuster_unittest.cc View 1 chunk +0 lines, -168 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/video_coding/include/bitrate_adjuster.h View 1 chunk +0 lines, -89 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
emircan
PTAL.
4 years, 8 months ago (2016-04-26 18:29:22 UTC) #4
tkchin_webrtc
lgtm added stefan for common_video owners
4 years, 8 months ago (2016-04-26 18:38:29 UTC) #6
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-26 18:42:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914893005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914893005/20001
4 years, 8 months ago (2016-04-26 19:19:49 UTC) #9
kjellander_webrtc
lgtm
4 years, 8 months ago (2016-04-26 19:36:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-26 19:55:10 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:55:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55a401e607dfdca2f40c7b912c11a9c7e6b10f86
Cr-Commit-Position: refs/heads/master@{#12515}

Powered by Google App Engine
This is Rietveld 408576698