Allow the localhost IP address even if it does not match the tcp port address

This fixes an issue similar to
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address.
The issue here is in the TCP port.

BUG=
R=pthatcher@webrtc.org

Committed: https://crrev.com/6705012904e6cbbefce6fbce0a3f615b7aeafd8f
Cr-Commit-Position: refs/heads/master@{#12707}

[honghaiz3, 2016-04-23 00:32:23]

Description was changed from

==========
To allow the TCP connection succeed even if the socket ip address is a
localhost.


BUG=
==========

to

==========
This fixes an issue similar to the turn/tcp port issue where the localhost IP
does not match the turn port address:
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927


BUG=
==========

[honghaiz3, 2016-04-26 18:41:17]

Description was changed from

==========
This fixes an issue similar to the turn/tcp port issue where the localhost IP
does not match the turn port address:
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927


BUG=
==========

to

==========
This fixes an issue similar to 
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address:


BUG=
==========

[honghaiz3, 2016-04-26 18:42:53]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-04-26 18:43:16]

honghaiz@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[honghaiz3, 2016-04-26 18:48:35]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2016-04-26 18:49:20]

Patchset #1 (id:40001) has been deleted

[honghaiz3, 2016-04-26 19:29:15]

Description was changed from

==========
This fixes an issue similar to 
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address:


BUG=
==========

to

==========
This fixes an issue similar to 
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address. 
The issue here is in the TCP port.

BUG=
==========

[honghaiz3, 2016-05-04 22:34:21]

Ping for review.

[pthatcher1, 2016-05-06 22:47:30]

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport.cc
File webrtc/p2p/base/tcpport.cc (right):

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport.c...
webrtc/p2p/base/tcpport.cc:393: << socket_addr.ToSensitiveString();
This isn't an accurate log.  You're saying "to", but giving the "from" address.

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport.c...
webrtc/p2p/base/tcpport.cc:406: << ". Still allowing it since it's a local
host.";
it's a local host => it's localhost

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport_u...
File webrtc/p2p/base/tcpport_unittest.cc (right):

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport_u...
webrtc/p2p/base/tcpport_unittest.cc:44: ss_->SignalSocketCreated.connect(this,
&TCPPortTest::OnSocketCreated);
Why not just do this in the constructor?

[honghaiz3, 2016-05-06 23:25:22]

Thanks! PTAL.

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport.cc
File webrtc/p2p/base/tcpport.cc (right):

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport.c...
webrtc/p2p/base/tcpport.cc:393: << socket_addr.ToSensitiveString();
On 2016/05/06 22:47:30, pthatcher1 wrote:
> This isn't an accurate log.  You're saying "to", but giving the "from"
address. 

Changed to the "to" address.

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport.c...
webrtc/p2p/base/tcpport.cc:406: << ". Still allowing it since it's a local
host.";
On 2016/05/06 22:47:30, pthatcher1 wrote:
> it's a local host => it's localhost

Done.

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport_u...
File webrtc/p2p/base/tcpport_unittest.cc (right):

https://codereview.webrtc.org/1914803002/diff/80001/webrtc/p2p/base/tcpport_u...
webrtc/p2p/base/tcpport_unittest.cc:44: ss_->SignalSocketCreated.connect(this,
&TCPPortTest::OnSocketCreated);
On 2016/05/06 22:47:30, pthatcher1 wrote:
> Why not just do this in the constructor?

Because we don't want to connect this signal for the first two sockets created
(when creating the TcpPorts).

[pthatcher1, 2016-05-06 23:33:03]

lgtm

[honghaiz3, 2016-05-12 00:39:07]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-05-12 00:39:07]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1914803002/#ps120001 (title:
"Merge with head")

[commit-bot: I haz the power, 2016-05-12 00:39:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914803002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914803002/120001

[commit-bot: I haz the power, 2016-05-12 00:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 00:47:46]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13207)

[honghaiz3, 2016-05-12 01:43:05]

The CQ bit was checked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2016-05-12 01:43:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914803002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914803002/120001

[commit-bot: I haz the power, 2016-05-12 01:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 01:49:26]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13208)

[honghaiz3, 2016-05-12 16:28:11]

Description was changed from

==========
This fixes an issue similar to 
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address. 
The issue here is in the TCP port.

BUG=
==========

to

==========
This fixes an issue similar to
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address.
The issue here is in the TCP port.

BUG=
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/6705012904e6cbbefce6fbce0...
==========

[honghaiz3, 2016-05-12 16:28:13]

Committed patchset #4 (id:120001) manually as
6705012904e6cbbefce6fbce0a3f615b7aeafd8f (presubmit successful).

[commit-bot: I haz the power, 2016-05-12 16:28:16]

Description was changed from

==========
This fixes an issue similar to
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address.
The issue here is in the TCP port.

BUG=
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/6705012904e6cbbefce6fbce0...
==========

to

==========
This fixes an issue similar to
https://bugs.chromium.org/p/webrtc/issues/detail?id=3927
where the localhost IP does not match the turn port address.
The issue here is in the TCP port.

BUG=
R=pthatcher@webrtc.org

Committed: https://crrev.com/6705012904e6cbbefce6fbce0a3f615b7aeafd8f
Cr-Commit-Position: refs/heads/master@{#12707}
==========

[tommi, 2016-05-13 14:39:20]

A revert of this CL (patchset #4 id:120001) has been created in
https://codereview.webrtc.org/1979463003/ by tommi@webrtc.org.

The reason for reverting is: Speculatively reverting due to failures on the
memcheck bot (and possibly other bots):

https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/5....