Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1913603002: Compensate for the compression gain in the IntelligibilityEnhancer (Closed)

Created:
4 years, 8 months ago by aluebs-webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Compensate for the compression gain in the IntelligibilityEnhancer The render signal that reaches the IE is already normalized and compressed by an AGC on the far-end capture processing. Because the noise estimation is done before the AGC compression, we need to compensate for this gain in the IE to be able to compare these 2 powers. Committed: https://crrev.com/11d4a42ce5aecae3885498a22254b709687c07e8 Cr-Commit-Position: refs/heads/master@{#12549}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Use foreach loop #

Patch Set 3 : Add unittest #

Total comments: 2

Patch Set 4 : Naming #

Messages

Total messages: 18 (6 generated)
aluebs-webrtc
4 years, 8 months ago (2016-04-22 21:35:59 UTC) #2
peah-webrtc
https://codereview.webrtc.org/1913603002/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc File webrtc/modules/audio_processing/audio_processing_impl.cc (right): https://codereview.webrtc.org/1913603002/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc#newcode711 webrtc/modules/audio_processing/audio_processing_impl.cc:711: public_submodules_->gain_control->compression_gain_db()); Is there some action in place to ensure ...
4 years, 7 months ago (2016-04-25 07:23:20 UTC) #3
hlundin-webrtc
Nice and short. But I wonder if you should add some unit testing for the ...
4 years, 7 months ago (2016-04-25 08:00:35 UTC) #4
turaj
LGTM, maybe add a few line to the CL's description why this is needed, or ...
4 years, 7 months ago (2016-04-25 13:51:13 UTC) #5
aluebs-webrtc
Addressed comments, added unittest and expanded description. PTAL. https://codereview.webrtc.org/1913603002/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc File webrtc/modules/audio_processing/audio_processing_impl.cc (right): https://codereview.webrtc.org/1913603002/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc#newcode711 webrtc/modules/audio_processing/audio_processing_impl.cc:711: public_submodules_->gain_control->compression_gain_db()); ...
4 years, 7 months ago (2016-04-27 22:52:58 UTC) #7
hlundin-webrtc
lgtm https://codereview.webrtc.org/1913603002/diff/1/webrtc/modules/audio_processing/gain_control_impl.h File webrtc/modules/audio_processing/gain_control_impl.h (right): https://codereview.webrtc.org/1913603002/diff/1/webrtc/modules/audio_processing/gain_control_impl.h#newcode54 webrtc/modules/audio_processing/gain_control_impl.h:54: int compression_gain_db() const override; On 2016/04/27 22:52:58, aluebs-webrtc ...
4 years, 7 months ago (2016-04-28 06:19:01 UTC) #8
aluebs-webrtc
peah, any additional comments? https://codereview.webrtc.org/1913603002/diff/40001/webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc File webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc (right): https://codereview.webrtc.org/1913603002/diff/40001/webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc#newcode411 webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc:411: const float kGainTimes = std::pow(10.f, ...
4 years, 7 months ago (2016-04-28 17:30:09 UTC) #9
peah-webrtc
On 2016/04/28 17:30:09, aluebs-webrtc wrote: > peah, any additional comments? > > https://codereview.webrtc.org/1913603002/diff/40001/webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc > File ...
4 years, 7 months ago (2016-04-28 18:53:24 UTC) #10
aluebs-webrtc
On 2016/04/28 18:53:24, peah-webrtc wrote: > On 2016/04/28 17:30:09, aluebs-webrtc wrote: > > peah, any ...
4 years, 7 months ago (2016-04-28 19:58:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913603002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913603002/60001
4 years, 7 months ago (2016-04-28 19:59:05 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-28 21:58:36 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:25 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/11d4a42ce5aecae3885498a22254b709687c07e8
Cr-Commit-Position: refs/heads/master@{#12549}

Powered by Google App Engine
This is Rietveld 408576698